Re: [PATCH 1/2] tools/libs: light: Remove the variable 'domainid' do_pci_remove()

[Julien Grall <julien@xxxxxxx>]

Hi Anthony,

On 18/08/2023 18:05, Anthony PERARD wrote:
> On Wed, Aug 09, 2023 at 11:33:04AM +0100, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > The function do_pci_remove() has two local variables 'domid' and
> > 'domainid' containing the same value.
> >
> > Looking at the history, until 2cf3b50dcd8b ("libxl_pci: Use
> > libxl__ao_device with pci_remove") the two variables may have
> > different value when using a stubdomain.
> >
> > As this is not the case now, remove 'domainid'. This will reduce
> > the confusion between the two variables.
> >
> > Note that there are other places in libxl_pci.c which are using
> > the two confusing names within the same function. They are left
> > unchanged for now.
> >
> > No functional changes intented.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks! I have committed this patch. I need to respin patch 2.

Cheers,

--
Julien Grall