[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] CI: Always move the bisect build log back
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 24 Aug 2023 12:02:26 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nX/hIreYGsxXtN68ZiAGbsu5dMdperP/Tp6jCd1TKRk=; b=Vff2KG6c4n0STqIQpTo7KqjRgmxZ3aS7PHggxhEpWLPXURCQnf8EcdOT9iNebOon76KiMMM8izTs8m2cFYb//h7DtEls6shvSiGbZcy0gKkkFIobVIGyMato+kx2vcuGg4Q+X+mxYI+CT4RMUB8eL4utOOHG9j7lb3WXkyXYsoAZVVEkSyHuu3BLkuYfPdwYEBNzYddmU5sfe1QdcjLvw2OM11c7ECM1Nh2OB8OAJZOVL0DwirGO6qQCeDMaFfc7rC+MhVwZXtLz4WnFFmI8QbjnMbruWbqmiF+1M8FOpUs3u3g+zGPIHvMZw8RHTNSqTO5BEgWsGlqT2dH614J8Kw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4kYaIMDImswENCq6faipPkUweA5k5DoHyDuvoZHPQLM/U1GXDOZ4zLgtWUNIFNsPuZwkT9Sw5M4NCtqshrip/NOInJs6I+/dTBq+Y3ZO95Pdons3hTz4Rg7KvWrv6VRDS7/rh/p79YCeVH+aZrGmG1g79HqWmgeblGHcVhdyReyhPxZvAoKU1wMtcNzDnjv4oHflBYOvjzRcXTwCmM1fe3AkSdIpVux9swMJnxYFGuNHwA2VFaPy2OFGJF9UzvV2JtAbG5dzySHcoGUQyPQD8DQfukD1vxzr2xQStC0gWuk6KD7fsAd2QIH3VPGzoPcYCIQQIgM4FGNTvC5IgMwcQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 24 Aug 2023 11:02:59 +0000
- Ironport-data: A9a23:jduU/Ks2WACEaEYvwrNb19OQUOfnVGBfMUV32f8akzHdYApBsoF/q tZmKTrUMvjZYDT2Ko9zb9vn8khS78CHzIQ1QFNs+CA3FykR+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5A+EzCFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwCy40QhmNou2M8quqR+pPm9sPfMXTM9ZK0p1g5Wmx4fcOZ7nmGv+PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ovjv6xbbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTpqaEw2APJroAVIDYqdkTl+tqosXavGPZyF 0ko8Tguo6dnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQh3 0WFmN7BDjV1vLqYD3ma89+8tiiuMCIYKWsDYy4sTgYf5dTn5oYpgXryos1LFae0ipjwBmv2y jXT9iwm3e1P0IgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2tYji0bnlePSxfdgw
- Ironport-hdrordr: A9a23:gi8fOqqrqdh7qXg+wBfUgywaV5oleYIsimQD101hICG9E/b1qy nKpp8mPHDP5wr5NEtPpTnjAsm9qALnlKKdiLN5Vd3OYOCMghrKEGgN1/qG/xTQXwH46+5Bxe NBXsFFebnN5IFB/KTH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/08/2023 11:48 am, Anthony PERARD wrote:
> On Thu, Aug 24, 2023 at 10:51:20AM +0100, Andrew Cooper wrote:
>> On 24/08/2023 9:52 am, Anthony PERARD wrote:
>>> On Wed, Aug 23, 2023 at 07:05:56PM +0100, Andrew Cooper wrote:
>>>> On 23/08/2023 4:23 pm, Anthony PERARD wrote:
>>>>> On failure of "build"-each-commit script, the next command that move
>>>>> the log back into the build directory isn't executed. Fix that by
>>>>> using "after_script" which is always executed even if the main
>>>>> "script" fails. (We would still miss the log when the jobs times out.)
>>>>>
>>>>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>>>> ---
>>>>> automation/gitlab-ci/test.yaml | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/automation/gitlab-ci/test.yaml
>>>>> b/automation/gitlab-ci/test.yaml
>>>>> index 810631bc46..5099f2e6b6 100644
>>>>> --- a/automation/gitlab-ci/test.yaml
>>>>> +++ b/automation/gitlab-ci/test.yaml
>>>>> @@ -140,6 +140,7 @@ build-each-commit-gcc:
>>>>> CC: gcc
>>>>> script:
>>>>> - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}}
>>>>> TIP=${TIP_SHA:-${CI_COMMIT_SHA}}
>>>>> ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee
>>>>> ../build-each-commit-gcc.log
>>>>> + after_script:
>>>>> - mv ../build-each-commit-gcc.log .
>>>>> artifacts:
>>>>> paths:
>>>> Thanks for looking into this, and yeah that is dumb, but why play games
>>>> with the parent directory?
>>> `git clean -ffdx` has the tendency to remove everything that's not
>>> committed, that's why. But maybe we can teach ./build-each-commit.sh to
>>> ignore that logfile.
>> Oh, right. Yeah, lets not lose the log file like that.
>>
>> I'd say that teaching `git clean` to leave the file interacted and not
>> copying it is going to be a more robust option.
> Yep, just tried that. But "Tree is dirty, aborted" :'(
>
> ./build-test.sh refuses to run if there's something in the git worktree.
>
> This test is going to need more rework to be useful in the gitlab-ci.
Urgh fine. Lets just go with your fix in the short term. It's
definitely better than nothing.
~Andrew
|
