[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Need Ack, Re: [XEN PATCH v4 3/4] x86/viridian: address violations of MISRA C:2012 Rule 7.2



Paul, Wei, can we have an ack?


On Thu, 24 Aug 2023, Nicola Vetrini wrote:
> On 26/07/2023 13:03, Simone Ballarin wrote:
> > From: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
> > 
> > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> > headline states:
> > "A 'u' or 'U' suffix shall be applied to all integer constants
> > that are represented in an unsigned type".
> > 
> > Add the 'U' suffix to integers literals with unsigned type and also to other
> > literals used in the same contexts or near violations, when their positive
> > nature is immediately clear. The latter changes are done for the sake of
> > uniformity.
> > 
> > Signed-off-by: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
> > Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > ---
> > Changes in v4:
> > - change commit headline
> > - add Reviewed-by
> > 
> > Changes in v3:
> > - create this commit for 'viridian.c' and 'hyperv-tlfs.h'
> > ---
> >  xen/arch/x86/hvm/viridian/viridian.c         |  2 +-
> >  xen/arch/x86/include/asm/guest/hyperv-tlfs.h | 28 ++++++++++----------
> >  2 files changed, 15 insertions(+), 15 deletions(-)
> > 
> 
> This patch has perhaps slipped by since its submission. As it can be applied
> on top of
> staging without conflicts, then it probably needs an ack from the x86 viridian
> maintainers.
> 
> -- 
> Nicola Vetrini, BSc
> Software Engineer, BUGSENG srl (https://bugseng.com)
> 



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.