[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Need Ack, Re: [XEN PATCH v4 2/4] xen/vpci: address violations of MISRA C:2012 Rule 7.2



Please ack

On Thu, 24 Aug 2023, Nicola Vetrini wrote:
> On 26/07/2023 13:03, Simone Ballarin wrote:
> > From: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
> > 
> > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> > headline states:
> > "A 'u' or 'U' suffix shall be applied to all integer constants
> > that are represented in an unsigned type".
> > 
> > Add the 'U' suffix to integers literals with unsigned type and also to other
> > literals used in the same contexts or near violations, when their positive
> > nature is immediately clear. The latter changes are done for the sake of
> > uniformity.
> > 
> > Signed-off-by: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
> > Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > ---
> > Changes in v4:
> > - change commit headline
> > 
> > Changes in v3:
> > - change 'Signed-off-by' ordering
> > - add 'uint32_t' casts in 'msi.c' and 'msix.c'
> > 
> > Changes in v2:
> > - minor change to commit title
> > - change commit message
> > ---
> >  xen/drivers/vpci/msi.c  | 2 +-
> >  xen/drivers/vpci/msix.c | 2 +-
> >  xen/drivers/vpci/vpci.c | 6 +++---
> >  3 files changed, 5 insertions(+), 5 deletions(-)
> > 
> 
> Like other patches in this series, this one could also benefit from an ack
> from
> VPCI maintainers to get committed, as it does apply cleanly on staging.
> 
> -- 
> Nicola Vetrini, BSc
> Software Engineer, BUGSENG srl (https://bugseng.com)
> 



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.