[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v9 04/19] common/device_tree: Export __unflatten_device_tree()
- To: Julien Grall <julien@xxxxxxx>
- From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- Date: Thu, 24 Aug 2023 17:54:40 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1hQBKzXpWHZ4SsXl7ISxxtI+lq1+fzUmI62LcvNTqxE=; b=g3IhBxisPyR57uEFT/ER2FdyLAtuMnwmYM1+VZh5M14pt41gUfyydIAZa4ieB1bIW8C0OvFJVDE36zH1/zJqev2HY2/bMYDtv7vj2cT4JkuYL5k9EFuhq4TXkgo93biTX4APPLgpzaSdT2IQG/wMD52WfI9i1FHE54xBlloAqoleF3OLxZmRViMM7vFfwKoxI5IMU4NQhL3RHaMkUGkxd+ZZwYX2NOhaO151sQ3qsFA7EA3rQGQer2yDjMRXb15QrZ3Z/LkD3TIZsvSD1+zOvCXopHrB8uquUcHCbZHSbMg2F8Kx1bizHXAsuXQ4SRXYnKlR1pKCwKE2wPesZwh1aQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YFLjuS83GO32phk63nWnLAlY6+gVwvY5wBtoU+u0x2YH4c/0/xE5hT9gbNBtHyY3/em6z6aDV9X3u5w674OBYHi7K1noijcYceWPvfZB37M4P5XiAzeB7rEXVHKNikTt06GTZ4vo77Mz41TnRiRRBN5cxeQEjp5s7nk9Ftul+RqVAa/GZq30RexY5XFqVAq1iH9I4/e3vLsxhQ78Nohwo/8xowzjrGSrpmPiOF5wcHHXVgewZdte/hie8/Y/H+Z36WrT3iayFKYXbEOsiwtNFYlPJz/RMuiSxuVLWpu5FNfrlEB9M7ii7S24t+qapo4pytlS8saONHgvKijyoYH8Uw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, michal.orzel@xxxxxxx, sstabellini@xxxxxxxxxx, jbeulich@xxxxxxxx
- Delivery-date: Fri, 25 Aug 2023 00:54:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On Tue, Aug 22, 2023 at 08:05:18PM +0100, Julien Grall wrote:
> Hi Vikram,
>
> On 19/08/2023 01:28, Vikram Garhwal wrote:
> > Following changes are done to __unflatten_device_tree():
> > 1. __unflatten_device_tree() is renamed to unflatten_device_tree().
> > 2. Remove __init and static function type.
> >
> > The changes are done to make this function useable for dynamic node
> > programming
> > where new device tree overlay nodes are added to fdt and further unflattend
> > to
> > update xen device tree during runtime.
> >
> > Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
>
> It is not clear to me whether you saw my reply about using ERR_PTR() as I
> can't find an answer.
>
I saw the comment but was not able to work on implementing ERR_PRT(). Given that
I see your Acked-by, i will try to address this as separate patch after this
series.
> Anyway, I am not against this interface:
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> Cheers,
>
> --
> Julien Grall
|
