[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 10/13] xen/efi: address violations of MISRA C:2012 Directive 4.10
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 29 Aug 2023 08:47:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/1484RxhoZ5LqDBRVE/YfSqI/+t8It9Ms1UanNFR42I=; b=QpD0er0ZBhlCN3y3fX56JbqQmQMArGv0OVizWTbLAaQbRxOSXisDxXPOIm0qJUZtC3BWkI1BF1U1Dh+baelvoe+TUmflLlR4HOoJJ7a6wkBbM9dm7rM6vbZscvXysKZKz4CyFVfno5pYQ58gBvYKTSTFUQE6/8Gn0ArmCu6TWwFwnVyp9K/87vAy1lN5qyNMUh/H5a00refM1nId/q+cncfFa/41su46dsAjz07jcahE77E00f7UWR1Cdu2h3JRo3a5Hi/SfAQg58wepi6wjeENR9VLgOQ85SgQoAEf8/SOWmRB7hzUBNLnqCCpTaTpXyl3UoJ8x/sHfWxQ5qfXUlg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B7WPv+eHJMgIPXrI/c6DpcgmPN6q0liLsVltnbw6A+OYisNYMyyS1ih8XRJW8Y8E3kth/SVAMZU/qKl8SbHz/nd2rO8xJShwUu8giBA9Wxf5mAKdAq7WYpRE5FSEaWs9ZMdjjQLFi7KTg1z60ZCnqsqEL8ZqP1tTVV6/fLL6qBxhWnxJptRI/saWmaJa62gFLGqZV6pRynX6rVL7XGiMzIC3xL3wrov740EBp8ETvbXJgJMBnHmpnUPjVgYXKHDpgiIJ5f9QvwAKUGLexG/IrOJ0yKP4Am/8/SSqi87xkUqVKHWPHgLHYVpRgK5CF6bnxhWYDKCJ575mfm898P+Vcg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, consulting@xxxxxxxxxxx
- Delivery-date: Tue, 29 Aug 2023 06:47:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.08.2023 00:42, Stefano Stabellini wrote:
> On Mon, 28 Aug 2023, Simone Ballarin wrote:
>> --- a/xen/common/efi/runtime.c
>> +++ b/xen/common/efi/runtime.c
>> @@ -6,6 +6,10 @@
>> #include <xen/irq.h>
>> #include <xen/time.h>
>>
>> +#ifndef __COMMON_EFI_RUNTIME_C__
>> +#define __COMMON_EFI_RUNTIME_C__
>
> Shouldn't this be at the top of the file?
Imo .c files shouldn't gain guards in the first place.
Jan
|
