[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 12/13] xen: address violations of MISRA C:2012 Directive 4.10
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 29 Aug 2023 08:54:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yBdyY7ht4ZrUvUj1VkvWPtywKpiekhbV4az19USI/8Q=; b=jHgLFlY1nCT9ow/OZd6Z7iP04aDmgwKMMzPHWnfXNGbHxzQlDeKRmihE2GcNjncZwodi7Wk3Ybhesb41XPiAv+qVnWbU2Xa+vbYk8IBmvU4nElwfRVMTCxcH+0PosabiAUqwaimSIffyhe9btAnm5DI26+ZC1rOMv/RpV++lhffZtz2lz5t5qW8ntOcNl6SHsTWYkZPnrjd9cVXbkG7GFLrlQKhbnzDmkpkDl09OHHxES5dJzExX/TpwCgyWDA29J+zIlHESQXvMyGerZ7c/mYtPkV9shRtElC4rLce2gNIzTdfheJptdOf+Yo3/V98YrT18My35xnzhZL+tZ8TCuQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZd4h80ZhUvkXYLnpMJnOj+o4ariGRtp/KkMn9/2OJxOXnQCsEwd/a81wHpAanHamU7RU388UDoZCOxXJehodJWoILpyul8PY/pcRTYSWbkgolRNOcPFkPMTtdepHPOBBDzTV5OhIOtuMzEuP5pRrevj8lH2SBzomAQIP7EujK7TfLwsPHPzKfNXuvS9BCTF4au1Koapq/TC96HKytJMf3SODgx491MEa52AyAJ7s1rQH//hppXRI7eC9M3kgf3bVynG2y1NSfhGmkn3Su2xsvwfgVayf+2XGq2fDCgUq97ienrg9wYfGlcFDh/6Ebuf98deRm9yE2ajhf5JRA7iDA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, sstabellini@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 29 Aug 2023 06:55:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.08.2023 15:20, Simone Ballarin wrote:
> --- a/xen/include/xen/unaligned.h
> +++ b/xen/include/xen/unaligned.h
> @@ -3,13 +3,14 @@
> * without faulting, and at least reasonably efficiently. Other
> architectures
> * will need to have a custom asm/unaligned.h.
> */
> -#ifndef __ASM_UNALIGNED_H__
> -#error "xen/unaligned.h should not be included directly - include
> asm/unaligned.h instead"
> -#endif
>
> #ifndef __XEN_UNALIGNED_H__
> #define __XEN_UNALIGNED_H__
>
> +#ifndef __ASM_UNALIGNED_H__
> +#error "xen/unaligned.h should not be included directly - include
> asm/unaligned.h instead"
> +#endif
In addition to what Stefano said, this repositioning also is questionable
(as per comments elsewhere). Overall it looks like the entire patch wants
dropping? Or wait, no, the pci_ids.h change would remain.
Jan
|
