[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v10 08/20] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 29 Aug 2023 09:41:11 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E/Ew64MZX3WcrpMkh21UO9lEiTgFg85st2io3A5TiHM=; b=dinOE8JDLAql4Rbb3zKb7T3BpelM7u1UFXhWK6dFgrVR/5eMQIZ1cwM7uR8qApCBrkqvcQfpvyJ2IuVkc+DdCjhDeJkUivxAsqc+zqUWU9u1RoXk8FHbrctz8tV5Hdp8mdyBWhrfEdukjowXc6Szui8Jp4qsJfT6rx/ay/887s1UDG9rtUtAYisnRkm7lcQHGcEze6szeLjrF1NWKh6HIXVO6ks49f68I9EnjSOMB4ifYhARQRdDMbIfIeEBhmpZ86jFycU8wGek/lC9V2QN+xPtjIFgyIcNHb7O66T+cCWYBwU5Y3lEcGViiomG0gLGsecVx+35mDUPuFyTctLXag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFu8JmKvZXsFk71A5SPL7qUSJZG2B2qZlvXGTiOSWUIHgWpJyXl5uDvEYBx1GAb7ubC48A+EzN/dwHHXXQW0ej4pcxbirdnwDewcWJqOWSC7o/6sLh5t+AtB6paG0KSjisTfbxeQNlfN3Xwvmcm/v396nbVdmikac67JMNz/oRxO0X6InN1KkZrkXSjlnmdiZU+CPS47Yn54XgALL8DPSP1qBuW17SbvVCBayrZAyJO/GjcJ+OkhaL/Esc4HNXe1pCd81LncijXXKBI3GArvgckC2sGttLPztX7skAo4CdO+d+kNV0g9UCIC3OHRrrOF3U96ETUUFiWtiNxjzeKM9Q==
- Cc: <sstabellini@xxxxxxxxxx>, <julien@xxxxxxx>
- Delivery-date: Tue, 29 Aug 2023 07:41:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25/08/2023 10:02, Vikram Garhwal wrote:
>
>
> Add device_tree_find_node_by_path() to find a matching node with path for a
You renamed it in v8 so both here and in commit title:
s/device_tree_find_node_by_path/dt_find_node_by_path_from/
> dt_device_node.
>
> Reason behind this function:
> Each time overlay nodes are added using .dtbo, a new fdt(memcpy of
As Julien requested: add space between fdt and (
> device_tree_flattened) is created and updated with overlay nodes. This
> updated fdt is further unflattened to a dt_host_new. Next, we need to find
> the overlay nodes in dt_host_new, find the overlay node's parent in
> dt_host
> and add the nodes as child under their parent in the dt_host. Thus we need
> this function to search for node in different unflattened device trees.
>
> Also, make dt_find_node_by_path() static inline.
>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
With the remarks addressed:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
