[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/2] xen: move arm/include/asm/vm_event.h to stubs
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 29 Aug 2023 14:19:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a1IK+qNb4jpQ2ObZMba4MsiajvAvssXcl/ld9UxUd5E=; b=c4Nt64mMuOmaJMW64oSsKtJd3dStjuwdU27VUT3dfJnh/yRcJ4EP4BHcy42poca6FwuQxM5klc/Ay4TbHOWuV8aSiXfPdtqMri5ZNxDAdDJc2Dtubvl+TiYgPnnZZrEJ6WxCTVQuZSzsrMBvp6BSY5IJMWmqruMvSd3JYN/erCahIhQ8O3jPMaMbrZM2HKkhz7k08fMxOd1F8P9F0HqCwUHLQ2uHCZNN+j9TJN1am6qvTlzuQtGWhH1Rb4dp9+xGfVAMpP+QGVTcHwrGbgYOw3MnzWFutKHxISPhZfjMeZij2TRcRKdEL9olPHAVz7F5pJCUoGfcw4An0XuQtv1cyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G6ozBHRMbUXbaXgx3ZAWCV0r2v5PbKOP+Su1utiox6JGd9W/XwBm240BwqUDtaewthEspEoRrlD6nXb0kT6UQ7MbJHAvI+LGfPA9BhPtssSvzC9HfrmBEVyctBrXfgNgxVDq92Yt/U3nMXrfqxEXzCUqxnfU04MVtT9Otx+Gg9418m6J/AOv87D5VTlLAS/odCya1ENavA8Zjkw5cDzFfXaziJ4JT8O4/OuEdKY+A2EBa2fhWP7RlkUKVpUP9i8tgkobRbrCNlfMY7d7oJ0P/C00m5jz2is9uhWYnSCgVnxMEXEzLw67CzC/RnDHouKfFoe18yBHrVEEmP46+v5/pw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 29 Aug 2023 12:19:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.08.2023 14:14, Oleksii wrote:
> On Mon, 2023-08-28 at 18:05 +0200, Jan Beulich wrote:
>> On 28.08.2023 17:57, Oleksii Kurochko wrote:
>>> +static inline void vm_event_cleanup_domain(struct domain *d)
>>> +{
>>> + memset(&d->monitor, 0, sizeof(d->monitor));
>>
>> This looks to be the sole reason that xen/sched.h is needed. I
>> question
>> the existence of that field in the first place when this stub is
>> being
>> used. But I guess cleaning that up as well might be going too far.
> What do you mean by the existence of the field? Looking at declaration
> of struct domain, monitor field always exists.
Right, and that's what I consider questionable.
> Could we leave initialisation of d->monitor for now?
As said, asking you to also do that aspect of cleanup is probably
going too far, so yes, I guess you can leave that alone.
Jan
|
