Re: [PATCH v2 2/2] xen: move arm/include/asm/vm_event.h to stubs

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 29 Aug 2023, Oleksii Kurochko wrote:
> asm/vm_event.h is common for ARM and RISC-V so it will be moved to
> stubs dir.
> 
> Original asm/vm_event.h from ARM was updated:
>  * use SPDX-License-Identifier.
>  * update comment messages of stubs.
>  * update #ifdef.
>  * change public/domctl.h to public/vm_event.h.
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> Changes in V2:
>  - change public/domctl.h to public/vm_event.h.
>  - update commit message of [PATCH v2 2/2] xen: move 
> arm/include/asm/vm_event.h to stubs
> ---
>  xen/arch/arm/include/asm/vm_event.h | 66 -----------------------------
>  xen/include/stubs/asm/vm_event.h    | 55 ++++++++++++++++++++++++
>  2 files changed, 55 insertions(+), 66 deletions(-)
>  delete mode 100644 xen/arch/arm/include/asm/vm_event.h
>  create mode 100644 xen/include/stubs/asm/vm_event.h
> 
> diff --git a/xen/arch/arm/include/asm/vm_event.h 
> b/xen/arch/arm/include/asm/vm_event.h
> deleted file mode 100644
> index 4d861373b3..0000000000
> --- a/xen/arch/arm/include/asm/vm_event.h
> +++ /dev/null
> @@ -1,66 +0,0 @@
> -/*
> - * vm_event.h: architecture specific vm_event handling routines
> - *
> - * Copyright (c) 2015 Tamas K Lengyel (tamas@xxxxxxxxxxxxx)
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms and conditions of the GNU General Public License,
> - * version 2, as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope it will be useful, but WITHOUT
> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> - * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> - * more details.
> - *
> - * You should have received a copy of the GNU General Public License along 
> with
> - * this program; If not, see <http://www.gnu.org/licenses/>.
> - */
> -
> -#ifndef __ASM_ARM_VM_EVENT_H__
> -#define __ASM_ARM_VM_EVENT_H__
> -
> -#include <xen/sched.h>
> -#include <public/domctl.h>
> -
> -static inline int vm_event_init_domain(struct domain *d)
> -{
> -    /* Nothing to do. */
> -    return 0;
> -}
> -
> -static inline void vm_event_cleanup_domain(struct domain *d)
> -{
> -    memset(&d->monitor, 0, sizeof(d->monitor));
> -}
> -
> -static inline void vm_event_toggle_singlestep(struct domain *d, struct vcpu 
> *v,
> -                                              vm_event_response_t *rsp)
> -{
> -    /* Not supported on ARM. */
> -}
> -
> -static inline
> -void vm_event_register_write_resume(struct vcpu *v, vm_event_response_t *rsp)
> -{
> -    /* Not supported on ARM. */
> -}
> -
> -static inline
> -void vm_event_emulate_check(struct vcpu *v, vm_event_response_t *rsp)
> -{
> -    /* Not supported on ARM. */
> -}
> -
> -static inline
> -void vm_event_sync_event(struct vcpu *v, bool value)
> -{
> -    /* Not supported on ARM. */
> -}
> -
> -static inline
> -void vm_event_reset_vmtrace(struct vcpu *v)
> -{
> -    /* Not supported on ARM. */
> -}
> -
> -#endif /* __ASM_ARM_VM_EVENT_H__ */
> diff --git a/xen/include/stubs/asm/vm_event.h 
> b/xen/include/stubs/asm/vm_event.h
> new file mode 100644
> index 0000000000..cc89ffe5fb
> --- /dev/null
> +++ b/xen/include/stubs/asm/vm_event.h
> @@ -0,0 +1,55 @@
> +/* SPDX-License-Identifier:  GPL-2.0 */

GPL-2.0 is deprecated, please use GPL-2.0-only

Aside from that:

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> +/*
> + * vm_event.h: stubs for architecture specific vm_event handling routines
> + *
> + * Copyright (c) 2015 Tamas K Lengyel (tamas@xxxxxxxxxxxxx)
> + */
> +
> +#ifndef __ASM_STUB_VM_EVENT_H__
> +#define __ASM_STUB_VM_EVENT_H__
> +
> +#include <xen/sched.h>
> +#include <public/vm_event.h>
> +
> +static inline int vm_event_init_domain(struct domain *d)
> +{
> +    /* Nothing to do. */
> +    return 0;
> +}
> +
> +static inline void vm_event_cleanup_domain(struct domain *d)
> +{
> +    memset(&d->monitor, 0, sizeof(d->monitor));
> +}
> +
> +static inline void vm_event_toggle_singlestep(struct domain *d, struct vcpu 
> *v,
> +                                              vm_event_response_t *rsp)
> +{
> +    /* Nothing to do. */
> +}
> +
> +static inline
> +void vm_event_register_write_resume(struct vcpu *v, vm_event_response_t *rsp)
> +{
> +    /* Nothing to do. */
> +}
> +
> +static inline
> +void vm_event_emulate_check(struct vcpu *v, vm_event_response_t *rsp)
> +{
> +    /* Nothing to do. */
> +}
> +
> +static inline
> +void vm_event_sync_event(struct vcpu *v, bool value)
> +{
> +    /* Nothing to do. */
> +}
> +
> +static inline
> +void vm_event_reset_vmtrace(struct vcpu *v)
> +{
> +    /* Nothing to do. */
> +}
> +
> +#endif /* __ASM_STUB_VM_EVENT_H__ */
> -- 
> 2.41.0
>