[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/8] xen/ppc: Add stub function and symbol definitions
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 30 Aug 2023 15:10:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pgnXlNHbOpp2PVphDUzUf/dDpsstOuKU9L8Dvc0zuho=; b=NbKZYqXUY1xn69lM8sIB59l2IW6ODUkVl1UbdmdKyT1ywh3pC068FPilyQtT8vbQum+sNmV0RbsyseUqgYrh0M/kWH4SM8g98tPGqYPB3M17fD6TX1j2SRT+e0Eg/DYwIOkokm1g9BzL2z6yNG49tcw+d6TOZEfT83eDp0iIQGm5LcTopq6VhKKh/bknhQwUahcy2zpWivqj/r5ZrI+O3lVBUECXKtazVVCzeA6mK190bu+YMSe9NS43FeKnpJ6xWyVz5Y4+zSllVppw3p5HyOHsefQ4Hb11vE7npftAdrdR/mwbnVznybfjec+eHtoq5MluQ+J7krbfl49aqOulwA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fpAK4ydViZcyshtsmb+tIpKluUYGMhCOaF+y8iYSVgyDCR8C+Y9srF4NMHeaX8/6XnBEUr30ecr2pwlLTK3F7jesKjtESLn3KgL5P53ra68nFzNRqn38bQvYk54gZTGr7UhUPygLiAyIRFi7gqNVPFEcPBXX0++oJXIac17ee6J0opcw07TP+u51eSYgO8D5U8DTjfeTYW2khXxq19R+Y2+l78wEH17miXJjFKg+y7htdOKBPiGgSz1EjT795OCTB8RNHVeSCUBEyd6UmDmfc0KvAKlNiyGKKAbDyE08+QQET/p/kIlfr/8uNslhCyCVWP8GL5p/fKfE0pvpWfyuVQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 30 Aug 2023 13:10:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.08.2023 22:07, Shawn Anastasio wrote:
> +/* irq.c */
> +
> +struct pirq *alloc_pirq_struct(struct domain *d)
> +{
> + BUG_ON("unimplemented");
> +}
> +
> +int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share)
> +{
> + BUG_ON("unimplemented");
> +}
> +
> +void pirq_guest_unbind(struct domain *d, struct pirq *pirq)
> +{
> + BUG_ON("unimplemented");
> +}
> +
> +void pirq_set_affinity(struct domain *d, int pirq, const cpumask_t *mask)
> +{
> + BUG_ON("unimplemented");
> +}
> +
> +static void ack_none(struct irq_desc *irq)
> +{
> + BUG_ON("unimplemented");
> +}
> +
> +hw_irq_controller no_irq_type = {
> + .typename = "none",
> + .startup = irq_startup_none,
> + .shutdown = irq_shutdown_none,
> + .enable = irq_enable_none,
> + .disable = irq_disable_none,
> + .ack = ack_none,
> +};
As said before, I think no new function should be introduced to fill any
of the hook pointers. I.e. I would suggest to also drop ack_none(). But
in the end it's your call of course. Either way
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
