[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/8] x86/hvm: Only populate info->cr2 for #PF in hvm_get_pending_event()
- To: Jinoh Kang <jinoh.kang.kr@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 30 Aug 2023 15:41:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x1bPQjcdTP9iQm25N43hO2+wK86V3V0MB9f2ZTY5AGQ=; b=Xo170HTD5yavZubxmYlqjEaZTIeaJS5CBPC+7MSOr8AWFBsOrJXM8kUCsI0BxxKfMhJg1hi6hsusY+0RckhLKMP3FhJdngj8dCoViRkySHQEbI1d2NAR8EO7HtIq0peSMjkFKwUxQ90cnb7F8ARAM86OOz2KYp8gKbGn1WJnjz/V+jUtTN6RVtZ7DnB2lXLGGOS8KddqaSKWjc1b9ndCUZ9tkjsx2leuTinUefszakt/oaLMs8sz5/WC6XAZA3j0g0dzElU9DP2QOfCjiVPQJh8zh4jR3bAQv/fjNnuDtgMMH+mUT2JsPYT6toBmYqnSwQcjKytMP/b6fNwBaWT9Aw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OYPyBK9+r3WPsx9WpyIe6eG4Ifs9FYVe9/TiA3U3us0M3FbXLMJMcejWRBIpuGoS6w3ufr297tK3Fi4RSn+6j9ExmdE0q6JRIG8tlWbGJh1pyC1Qk5cCQevEWndC2i6Ua0sYQB18kX+rqIAlqIL6vMDbmvaugQfki3v8qhTMFIXls5xfnm8j35dOF6podiZ+YUfA61LqIGtCGVQa7sKrKin6N8RDyljY75SwV6EqwlXNQAQUqt1tYpURbBqWhkQanF1Eupn5dFu0iMVeAI4NRfVNTQMdIwbyq8dvwyei7KC8mDgFqo4erd8DvcIC/yluUz+j2a5QN63En+1NmbzBiw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 30 Aug 2023 13:42:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.08.2023 17:25, Jinoh Kang wrote:
> Prepare for an upcoming patch that overloads the 'cr2' field for #DB.
Seeing the subsequent change and the fact that earlier on Andrew didn't
need such an adjustment, I'm afraid I can't see the need for this change,
and the one sentence above also doesn't answer the "Why?", but only the
"What?"
Jan
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -503,9 +503,14 @@ void hvm_migrate_pirqs(struct vcpu *v)
>
> static bool hvm_get_pending_event(struct vcpu *v, struct x86_event *info)
> {
> - info->cr2 = v->arch.hvm.guest_cr[2];
> + if ( !alternative_call(hvm_funcs.get_pending_event, v, info) )
> + return false;
> +
> + if ( info->type == X86_EVENTTYPE_HW_EXCEPTION &&
> + info->vector == X86_EXC_PF )
> + info->cr2 = v->arch.hvm.guest_cr[2];
>
> - return alternative_call(hvm_funcs.get_pending_event, v, info);
> + return true;
> }
>
> void hvm_do_resume(struct vcpu *v)
|
