Re: [XEN PATCH 06/13] x86/EFI: address violations of MISRA C:2012 Directive 4.10

[Simone Ballarin <simone.ballarin@xxxxxxxxxxx>]

On 29/08/23 15:27, Jan Beulich wrote:
> On 28.08.2023 15:20, Simone Ballarin wrote:
> > Add inclusion guards to address violations of
> > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order
> > to prevent the contents of a header file being included more than
> > once").
> >
> > Mechanical change.
> >
> > Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> > ---
> >   xen/arch/x86/efi/efi-boot.h | 6 ++++++
> >   xen/arch/x86/efi/runtime.h  | 5 +++++
> >   2 files changed, 11 insertions(+)
> >
> > diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
> > index 92f4cfe8bd..2c6be062cc 100644
> > --- a/xen/arch/x86/efi/efi-boot.h
> > +++ b/xen/arch/x86/efi/efi-boot.h
> > @@ -3,6 +3,10 @@
> >    * is intended to be included by common/efi/boot.c _only_, and
> >    * therefore can define arch specific global variables.
> >    */
> > +
> > +#ifndef __X86_EFI_EFI_BOOT_H__
> > +#define __X86_EFI_EFI_BOOT_H__
> Considering the comment, I find the need for a guard here quite
> "interesting", to be honest.
>
> Jan
I don't think a simple comment is enough to say that "precautions have 
been taken". For the moment, I will drop this change to keep this patch 
going.
--
Simone Ballarin, M.Sc.

Field Application Engineer, BUGSENG (https://bugseng.com)