[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] xen: move arm/include/asm/vm_event.h to asm-generic
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 31 Aug 2023 11:46:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GtbEwX4+oS3nKOuBCAwjX38rPt2R6/w4KjD5Mr34F+M=; b=NB9xElV+tihS4DmmvMHYsRsUgwFiRSqGTvA5kwQA1S/WQAXaPlYHQJnEAAf7neKtxhb/5jozz7NCBdzZ/mtxPXa/aXMMVzl2MemiGgf9LnO/jjfqr6EFmN+xps+f9rg0ONzXasbBRePO2ca9NX1PaLoIqT21FMO6QcQtMf3//AvCqNG/+6ZCuKmJg6Z8mzl78MAd7E3HmQDsmZ6yJaAnczfp3isXM/bOSi1yb6lZfXUyw84oydKU5Lg4X6WPxZdD41JJMgxXKed4id6NkesAPCbYs0EuyP71euh/IJXQ0fd5bOrrscAN1TyWocOkR8j09P94QVxyNQS1q25W+72gow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O5VnJW7cYhp4xgXWb3KzQ+mtb3uQcFHBoUU6Ttl1CbrCo35paerKo+dF21pR+2mGipAHz14iaDQ3S23I9jV9q8xQb7pIudwjwyQkEU425mgqph7N197J2A0yTTyV0EgNjWVewyfL8KDld7jHo/Foz/pkWyjnqM0k0fmJnWUnyr3Xd3tJ3C01YCzIQK+x25J5jsVaAQqQdMJ9Z5/ZxijalsysuRbAqrJqbhlm/k9/aLJoHCpU1L+aW5zXQfMtVnImotClqTPSmmIVPNVvIvRoCC0+oD5FUNEL12NnKiL2iriWpX+ORHdU801kGTaVlq+mABTKd74POl86LmRYfNGC7w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 31 Aug 2023 09:46:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.08.2023 18:57, Oleksii Kurochko wrote:
> asm/vm_event.h is common for ARM and RISC-V so it will be moved to
> asm-generic dir.
>
> Original asm/vm_event.h from ARM was updated:
> * use SPDX-License-Identifier.
> * update comment messages of stubs.
> * update #ifdef.
> * change public/domctl.h to public/vm_event.h.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> ---
> Changes in V3:
> - add Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> for "xen: move
> arm/include/asm/vm_event.h to asm-generic"
> - update SPDX tag.
> - move asm/vm_event.h to asm-generic.
> ---
> Changes in V2:
> - change public/domctl.h to public/vm_event.h.
> - update commit message of [PATCH v2 2/2] xen: move
> arm/include/asm/vm_event.h to stubs
> ---
> xen/arch/arm/include/asm/vm_event.h | 66 --------------------------
> xen/include/asm-generic/asm/vm_event.h | 55 +++++++++++++++++++++
> 2 files changed, 55 insertions(+), 66 deletions(-)
> delete mode 100644 xen/arch/arm/include/asm/vm_event.h
> create mode 100644 xen/include/asm-generic/asm/vm_event.h
While it's a comment on the first patch, it's really better making here:
Did you look at Linux? They don't put an intermediate asm/ here. Instead
see their scripts/Makefile.asm-generic. That way an arch still has
control which generic headers it gets access to, without duplicating any
of them.
Jan
|
