[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/8] xen/ppc: Add public/arch-ppc.h


  • To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 1 Sep 2023 09:32:01 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ofsdvkR+CjFUdbZ9dCpr92+9gdnll11ftLZciaoTfY8=; b=BDerNULslbYx8ZZjBtJd+Xrr2raAdQpuByaze/1Q+CqyXxN4Tximn6sP4fCRC6B8bJXZC+fCODT6eOESoHV+DTcnq+EHYJH0HHwDXMRqJGw9AsT1W+00TOf1gXbZU1a4KgTe2Nywx/0PGp5SHhJX2qNSsOy+0Dj80vrFplIYEM6Dbb4Hl8Nzp92cheEqpud0pe/QVDiBIMqMPI1scPhQD9W85HLcqI8LmxOFhZ+Dt21Az1d73bQjz3p/b1+3LypwAW4GFXyAJFPJUfeLK6wFPF6fnq3CZEr5mFDOwD+MkVlw+4dncGQzgZPD7rd9Y+WTBRip9olqFYZ9Yh5/DvkoYg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n0xaBiOm7RyQjJvwfL1kr8XopbplxmNGNhMKY6wsG5uqsqLJ1Z04+wgTZi32kN7R+JtTp/E/MS8l+YekSXti8LIl0s2e60SPzHCXObEmEaJQ5XNjGtYHCk3CNs5NTv/FWIiSO2HzyIVceLX+Seu2dR7ClsHYptX3Cpgi1uArMNw8a0G2WZNSfe+TK4ayp68ij2n2zvH/LJgg//llo13/yK+37g/LbUO2ofAq5dtPEpMPsSPEhktjWp1JzmErDI8w2KtTdiYKnublo2AjkTlTHEQI8J/ZmfFUyxc86ZMDS28UYSqx+52ECDVxGAK1EEZUdZIJCyXFD5Gk3ButdBCePA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 01 Sep 2023 07:32:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.08.2023 22:07, Shawn Anastasio wrote:
> Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>

There's one more edit I did while committing:

> --- /dev/null
> +++ b/xen/include/public/arch-ppc.h
> @@ -0,0 +1,110 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Copyright (C) IBM Corp. 2005, 2006
> + * Copyright (C) Raptor Engineering, LLC 2023
> + *
> + * Authors: Hollis Blanchard <hollisb@xxxxxxxxxx>
> + *          Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>
> + *          Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
> + */
> +
> +#ifndef __XEN_PUBLIC_ARCH_PPC_H__
> +#define __XEN_PUBLIC_ARCH_PPC_H__
> +
> +#define  int64_aligned_t  int64_t __attribute__((__aligned__(8)))
> +#define uint64_aligned_t uint64_t __attribute__((__aligned__(8)))

These, using a GNU extension, cannot be exposed unconditionally. I've
submitted a corresponding patch for Arm [1], where I expect you took
this from.

Jan

[1] https://lists.xen.org/archives/html/xen-devel/2023-09/msg00037.html




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.