[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 4 Sep 2023 09:02:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XvhV8bJIXP3amXrNNZ88zPluy4GadBNN/caC65Jk+7Q=; b=XQ4+93zT643lmG6bjVyI0xWlNhWzmbIngoJeWDoaB9EhRPTeoID42PE0rxwuL00V03AUbnDCU6ep9PG7bYT93ml/yciV2pCgDoX6pN2/m2Rf4sxYJXmpSnmSgGAidVM3gPAwPu129KnD3TtPfTKI2pFdDLYQ9yUCz9i6viiRjVxFBIL7IxIyj+zB0xKrnWBCd7W/U+Ufd+NxkiUBOWUkyJJD8Ks/Tw5WuXCEEK2+MsCjnsqzGuOPTUypRO9geiHgQmR3Sy0wTN1CArRtkslkqb3KuKr9AZnrDtV1swDHxLtv4qEk7D5XrqRSXcpXvRcz4DSd2Z38qZNik08nfZprtw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4lhyL8vCK4vYf4xzx449y2SelLz92tXd3X0N7xYQO9oscSvWm1xtlJ2ncMnE69H9TPgE4DsjWXazmY6XgYNa7x1CXEVaKTI4i2esYu7h00CziMuFS77qL3ACeENnR9B81dVs02Nq7RwWp7T6wLqL1L3kHiKuuTU9XNUWp5SzMySJ1tAl5vo2yaiMeM8z080tVBMHPjQWhO7JlmeCDMWQJM6LrRx4cit/QkdtHMIxmGK+99FPzkFLW3XGCVmPDSkgn13f7FVZR5nfK1MgjhJGpqVUJqioY7/3s2RqMQEBdvfB/EDqttD02Gaxj/oXd5VgoxISXR0VKdJbc4bJ5gpeQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 04 Sep 2023 07:02:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.09.2023 18:34, Nicola Vetrini wrote:
> As stated in 'docs/misra/rules.rst' the functions that are used only by
> asm modules do not need to conform to MISRA C:2012 Rule 8.4.
> The deviations are carried out with a SAF comment.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
> Where the identifier for a function definition is on the next line w.r.t. the
> return type, they have been put on the same line (e.g. efi_start) to avoid
> stylistically questionable constructs, such as
>
> int
> /* SAF-1-safe */
> func(void) {
> ...
> }
And
/* SAF-1-safe */
int
func(void) {
is not an option?
Further in the cover letter you say "Deviating variables needs more care, and
is therefore postponed to another patch", yet then here you annotate a couple
of variables as well. Could you clarify what the criteria are for "needs more
care"?
Jan
|
