[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 5 Sep 2023 02:08:10 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=siZ6A8anDTZdFmb643EEAVg6Cf9ogYSzQ3fyBkqOWI8=; b=Irdsr/14+ocv5THUb/jUU65hjA2sAzjmWCov4W9NRk0Cam/wQjbE6JUaLamOIdKL0fn7PvgfXvdeRe2XkBYwgvqGfHyMuPMN9iW1BOfRXDka7sWlqphhsIK4NRLtvJSNP0ar/kp8mHh2aq0eO6Pg9h8HJZ1Hz7r2tS66ZZxDwvGJro2N0YBje/qUf6qp+8lfIyRyYiUtN1l524XIARngSFZ9+zgtQDJz8TVTdSrg4pRwiBMBxkNPNJE6lk/sV+Kkez5jwklXwE58ux3vFyJ7e63YiJWpfFqVtLr8TkSwZ9jKAhzZFLxdfOeMGJ0AmK5yB+lqRyh9mu3Bx295ENMnpg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i+4dV6e+YQGv1DKO3jx4F0GYPi3thyCaXV/6oihoCiRYRmyhQ7kmEqdYNL5LLVhlR7iGi4ZdKn31OBH1EKJkXE0s8iSbaTCp5cHl17VjhMqu/pNrio1hYKLOyMgsNxpLE9LuM6VQXxMF4tpToq+IYrE7GDmyty0JOuJSCngOj8eOPA+sBSOT6IIxonxa2S0f9wVngkXCurFQ2IPFT6UBBPcElaW3+ziZBBwtaA/7RYB+G2e7Gjjz8E08Xvj5m8e1E39mD6Qk6JRun/vVIpnsqz3I+lmQ0a58GyjNfHta4LTH/gVljFkEDiLyuyRMkanflx1LzKYHfvdHVIbrX/zdhw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Tue, 05 Sep 2023 02:08:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ3KW1QbAyYFQEp0mKJtVOIbYC5LALgkkA
- Thread-topic: [PATCH] Arm: constrain {,u}int64_aligned_t in public header
Hi Jan,
> On Sep 1, 2023, at 15:26, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> This using a GNU extension, it may not be exposed in general, just like
> is done on x86. External consumers need to make this type available up
> front (just like we expect {,u}int<N>_t to be supplied) - unlike on x86
> the type is actually needed outside of tools-only interfaces, because
> guest handle definitions use it.
>
> While there also add underscores around "aligned".
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -152,8 +152,10 @@
>
> #define XEN_HYPERCALL_TAG 0XEA1
>
> -#define int64_aligned_t int64_t __attribute__((aligned(8)))
> -#define uint64_aligned_t uint64_t __attribute__((aligned(8)))
> +#if defined(__XEN__) || defined(__XEN_TOOLS__)
> +#define int64_aligned_t int64_t __attribute__((__aligned__(8)))
> +#define uint64_aligned_t uint64_t __attribute__((__aligned__(8)))
> +#endif
Today I tested this patch by our CI (on top of today’s staging), and it looks
like below error will happen for both arm32 and arm64 Yocto build:
The arm32 failure:
https://pastebin.com/raw/S7ZqmG6z
The arm64 failure:
https://pastebin.com/raw/HMFh5tuS
Kind regards,
Henry
>
> #ifndef __ASSEMBLY__
> #define ___DEFINE_XEN_GUEST_HANDLE(name, type) \
>
|
