[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/ppc: Drop support for pseries/OpenFirmware
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 6 Sep 2023 08:44:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Em+oenfVRVwqQRq7ulmEQ3tFHmJloNlEfMFSV0WWKkE=; b=m4/6YU5YOW0ao1tEIMUaYT8uqNzhIL+A5AygbmvuARulAC4Wjg/I1bMxWxM+kmLYdDiP6XYUUOXwwvCkJmqAkW7HtWyztFxDmLLO0oAhbPjXaBRF4kgP38A633vg/OncPkMKQ4qbEHF+7+/xazWc2BFdGAO/iLJuKc/X4bxdTFdTeP8XRuwbBGrzEC7x0UC0XbIydvN8NhEz/nJ/1kJWYzIDnuh5JnB0lCdHzshc4gpSY1/fAy3RUr5qUWJati915VjHZtsyQgZnDQ/3yaaEh04r8WJL3N2P89Kr9VCj1ufX1EdJpEsJ3ZbdRakpvLqPjYUN0A19dnyt/wKY2SEyUQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MvBeI8zsJqTcNDCkNBo40VjljPC9h6cEnlW0R75wi/8hFaKLHuUHnI3nsQBpiejbhuBxewACfrz8r5dfJSn39ybIA42F3RusXpJwqFBd7UzRn9Mr+clhsmpIBop1FD2LwJXP+hahntZRSKjamtEx+zEZJTRVittvYz+JTfPZtiiaRy3U35TeSGRDU3KJjF8nUoU6UZCRE47Hobo9gt/cqgsMDBxYE8fuJ7XMdtqZiCr8x1YgT5eQIymnxBd5t6dIr5Y8awA9xNf/e3wK196C5vszsOrb14SmMJVTbWLzWK0LGAuwpzGN2qBK4+61Jg670m8aNV3ZvYgwfcqcWJNe9w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 06 Sep 2023 06:44:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.09.2023 23:46, Shawn Anastasio wrote:
> Since QEMU's PowerNV support has matured to the point where it is
> now suitable for development, drop support for booting on the
> paravirtualized pseries machine type and its associated interfaces.
I think you want to mention that the pseries functionality was actually
broken by the earlier change, both verbally and by means of a Fixes:
tag. The breakage actually may also want mentioning in patch 1 as well
as the cover letter.
> --- a/xen/arch/ppc/setup.c
> +++ b/xen/arch/ppc/setup.c
> @@ -14,17 +14,12 @@ void __init noreturn start_xen(unsigned long r3, unsigned
> long r4,
> {
> if ( r5 )
> {
> - /* OpenFirmware boot protocol */
> - boot_of_init(r5);
> + /* Unsupported OpenFirmware boot protocol */
> + __builtin_trap();
> }
> else
> {
> - /*
> - * kexec boot protocol
> - *
> - * TODO: This currently assumes an OPAL/PowerNV system, but it's also
> - * possible to be kexec'd on an OF system.
> - */
> + /* kexec boot protocol */
> boot_opal_init((void *)r3);
At least part of the comment may want retaining, as the code only handles
the OPAL case?
Jan
|
