[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] xen: asm-generic support
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 6 Sep 2023 14:16:56 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i7UDn+dimNEBgHL8FiTYLskYxVWJJaEICEuZRKCFwsU=; b=AnJij7T/nf0+gIKCvSoi8wKO84jydCk/AA8xHL+jdAJ6rnKfn2aC5Lc7o+0n4ek1TfN2YH7xsrjU4Y0zq5JjUqPOE/SHBNXaPmnx+988rOzpmk+iUQqbboPpaAjBiA5ooVAJAPaF26+SQ+LuMaqTmRyX3bD+21Xp4A9WMHF/vyaowREZ1/S7AHAc82DGbbvl/VykQb/xSc8QAnoJxv+2ufDaHh8vyXJ77A+rdrvJ2bloNXz2UaHK60xJh/JinX+Va1cutEUfqoIlE3rZl32UA2rfdfnollNqRSXbMHC45ONYLo9yPYiidkTAOGhdLnRRu+vOxQ5KIlgJACEEXXJ0rw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eka45vijPt0kpDhxMnPA6E+KgA0H/TapKNCcY89tbO6QaPYB9yWBXOIhHnv99d9EB+nIHBQocg9P3Sb+qQBRaJaR+kebxkFqWsFmnZhtuXMdAR8N0vilSTHK6C7UKvMPeoYWL3vefo7Q/sgWrVhbFqHuSfvkOiXq9ic+BbU0NDV0BgsUwDU/KefTkmLT6aFJ9mMwkh1A9WnyN5kW80AqVMpFpyI84/kMgIIEPYXMoCvYCjoZHW8axZ+nSxK0K+AURdrtXQZirE1kvrXd5LvbsLzBQY1q/BbzYL1Qpje/C/o7Dgq4EAd/0+aC9XvINtgUCOOMZLP2DVbCZGCI2Kb3xw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 06 Sep 2023 12:18:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.09.2023 18:02, Oleksii Kurochko wrote:
> --- /dev/null
> +++ b/xen/scripts/Makefile.asm-generic
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: GPL-2.0
While this is what the Linux file presently says, you still want to add
"-only", which is merely the newer name for the same thing.
> +# include/asm-generic contains a lot of files that are used
> +# verbatim by several architectures.
> +#
> +# This Makefile reads the file arch/$(SRCARCH)/include/asm/Kbuild
> +# and for each file listed in this file with generic-y creates
> +# a small wrapper file in $(obj) (arch/$(SRCARCH)/include/generated/asm)
> +
> +kbuild-file := $(srctree)/arch/$(SRCARCH)/include/asm/Kbuild
> +include $(kbuild-file)
> +
> +include scripts/Kbuild.include
> +
> +# Create output directory if not already present
> +_dummy := $(shell [ -d $(obj) ] || mkdir -p $(obj))
> +
> +quiet_cmd_wrap = WRAP $@
> +cmd_wrap = echo "\#include <asm-generic/$*.h>" >$@
> +
> +all: $(patsubst %, $(obj)/%, $(generic-y))
> +
> +$(obj)/%.h:
> + $(call cmd,wrap)
You've removed quite a bit of functionality, comparing with the Linux
original. May I ask why that is? What they have all makes sense to me,
and looks to be useful down the road.
Jan
|
