Re: [PATCH v4 1/2] xen: asm-generic support

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Wed, 2023-09-06 at 16:57 +0100, Anthony PERARD wrote:
> On Fri, Sep 01, 2023 at 07:02:14PM +0300, Oleksii Kurochko wrote:
> > diff --git a/xen/Makefile b/xen/Makefile
> > index f57e5a596c..698d6ddeb8 100644
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -667,6 +669,12 @@ endif # need-sub-make
> >  PHONY += FORCE
> >  FORCE:
> >  
> > +# Support for using generic headers in asm-generic
> > +PHONY += asm-generic
> > +asm-generic:
> > +       $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.asm-generic \
> > +                   obj=arch/$(SRCARCH)/include/generated/asm
> 
> Could you introduce a $(asm-generic) macro in Kbuild.include like we
> already have for $(build) and $(clean)? As I think it would be nicer
> to
> have
>         $(Q)$(MAKE) $(asm-
> generic)=arch/$(SRCARCH)/include/generated/asm
> in the main makefile.
> 
> Also, could you move the rule "asm-generic" within the "!config-
> build"
> part of the Makefile? Somewhere around the rule for $(TARGET), maybe
> just after the rule "_distclean".
> 
I pushed a new patch version tomorrow. I'll rework it based on your
comments here.

~ Oleksii