[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 4/4] xen/vpci: address a violation of MISRA C:2012 Rule 8.3
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 7 Sep 2023 15:32:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AV6hFc8kkfNLjI+EvQ52nGlucU71Gwfh6T5nrw61Ffs=; b=STig0WBGTrMjrdD8YJrjRasNdZtT1W0BX+tmAnu/40lTIX236OIcAggBCBr9MZ5RT3Vn8w44T16rpM/ZT9+RcqikJz5U/qhIwItCzNW1vwBnwR+T2G66yyqkjU7KydkgtS50rzgswDcWY+hhEgHQnvZos6n9DFkeJiklbNLZ0fAGHW6+uYDE31fmWTpwpqm1mSwbDx+euTGHaeRlqNbiFd7MZ7AtdbJHbmKvr4LUQ3XQX/31Xv9FpwlJEoLQZvmDAb08z2/JBdmyUhOWY19g1feMZptqN6JAXAw48bhVH4ZbQpr3d5cuF8eWHznsgeakY5zAVBbHQH8UB07utMVmOw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ELivh1qQZZ1iCrLon1c6PerbKNY7vqvzoPCFrgkcucDQErWzP71/5o/NwTY0wxG0GsKzO4HpJLHyaxtgetmNnnFpawKaQnGb4BBCQeI8+fAReKr0C4jHy45pxeGehUzypYD2o/ZhlaAIOtnAjLiVCxytwAo3YbtMsQKZne/Puu4kOIiTVw7x67OevV8sLKJ/BxSWOeTotk00ZcJPuWpHKgq8C7P0Yvy51nKC+MsX1akxUHuLRdJ5o7DJG/t0NdDtnnmN3+/Y7+ctboTO4l3P27vBovtepfrudaUgt6OFZfDTUMH2Pc3NUoKQHdUgPqbIVn/30TTduFmJKy7L/3aqnQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 07 Sep 2023 13:32:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.09.2023 10:57, Federico Serafini wrote:
> --- a/xen/arch/x86/include/asm/hap.h
> +++ b/xen/arch/x86/include/asm/hap.h
> @@ -30,7 +30,7 @@ void hap_vcpu_init(struct vcpu *v);
> int hap_track_dirty_vram(struct domain *d,
> unsigned long begin_pfn,
> unsigned int nr_frames,
> - XEN_GUEST_HANDLE(void) dirty_bitmap);
> + XEN_GUEST_HANDLE(void) guest_dirty_bitmap);
>
> extern const struct paging_mode *hap_paging_get_mode(struct vcpu *);
> int hap_set_allocation(struct domain *d, unsigned int pages, bool
> *preempted);
How is this related to vPCI? Plus if you change the HAP function, please
adjust its shadow counterpart too.
Jan
|