[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/x86: io_apic: Introduce a command line option to skip timer check
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 7 Sep 2023 16:09:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7htKJpGcGNnLTBF3vdUYIfyiw8g7gJZgdvQf8W12rGU=; b=hgUes0fSk3QsJXT95FGK2LUj+Q/n9Ia4J2GG1vRDK6sY7PiAjV2O1JdwwiB6Yk3dXbZJ17eoJrnpvFSPNPDO0ZJYYKmZxRH5c6Nar+HTI/RPkYibH7J1LmQiwx/H7UNt7A8fSdKzljfToFHVjPagkbtSjaLLXvMUZhOQJIqHOjbCHtsXjCBGGg2F+h3DEYurMn1/coXAS4OtKqnhA2nTMrbuSF/+qu+p3/dUMQZJ5Ctgsf05OuFAhgBGkG8GPppqsS97HQxefxK3Icu264vX9SNqRWHBVHN/D3r1EJ/aaVGgz/dNb1M5sHP8Qsg8QCBoeC2kO6JR+e8W95H7YXdf0g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzKdnSrpTqBD32xP+eCwiIQT9u4yKzw1F6vhjKYOjnKTLk37sOP0DBLkrBfzm+kW8pZGGWJl1KWGNg4kiEyqirBT4FsEoMFdH9DriO2mBjpwh0guaYg9lL6NqjcJxzozyP2XXM+5FNmP62//9kMIl006MlMvhXOlInRIWmRV6RbGbn/Dx2Jy5ZA+pO0oTaLAL27xu2wiTKaeeDmCNp5HyLeIWlHR0eYWg+CGKhO+hDnOnfjufHsjzkj+of3F4w2cqpI51FPji0ODWn0q2lUu53qqqpTnoK/ZDyJdrjBE+UVy9nhdso/8Y/SLyEGbg8SanMbzUEEEV3EFQoybGFyXmQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 07 Sep 2023 14:09:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.08.2023 15:44, Julien Grall wrote:
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1896,6 +1896,13 @@ This option is ignored in **pv-shim** mode.
> ### nr_irqs (x86)
> > `= <integer>`
>
> +### no_timer_works (x86)
> +> `=<boolean>`
> +
> +> Default: `true`
> +
> +Disables the code which tests for broken timer IRQ sources.
In description and code it's "check", but here it's "works". Likely
just a typo. But I'd prefer if we didn't introduce any new "no*"
options which then can be negated to "no-no*". Make it "timer-check"
(also avoiding the underscore, no matter that Linux uses it), or
alternatively make it a truly positive option, e.g. "timer-irq-works".
I also think it wants emphasizing that if this option is used and then
something doesn't work, people are on their own.
Jan
|
