[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] block: Clean up local variable shadowing
- To: Markus Armbruster <armbru@xxxxxxxxxx>
- From: Ilya Dryomov <idryomov@xxxxxxxxx>
- Date: Mon, 11 Sep 2023 13:17:32 +0200
- Cc: qemu-devel@xxxxxxxxxx, kwolf@xxxxxxxxxx, hreitz@xxxxxxxxxx, eblake@xxxxxxxxxx, vsementsov@xxxxxxxxxxxxxx, jsnow@xxxxxxxxxx, pl@xxxxxxx, sw@xxxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, paul@xxxxxxx, pbonzini@xxxxxxxxxx, marcandre.lureau@xxxxxxxxxx, berrange@xxxxxxxxxx, thuth@xxxxxxxxxx, philmd@xxxxxxxxxx, stefanha@xxxxxxxxxx, fam@xxxxxxxxxx, quintela@xxxxxxxxxx, peterx@xxxxxxxxxx, leobras@xxxxxxxxxx, kraxel@xxxxxxxxxx, qemu-block@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, alex.bennee@xxxxxxxxxx, peter.maydell@xxxxxxxxxx
- Delivery-date: Mon, 11 Sep 2023 11:18:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Aug 31, 2023 at 3:25 PM Markus Armbruster <armbru@xxxxxxxxxx> wrote:
>
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand. Tracked down with -Wshadow=local.
> Clean up: delete inner declarations when they are actually redundant,
> else rename variables.
For rbd
> block/rbd.c | 2 +-
Acked-by: Ilya Dryomov <idryomov@xxxxxxxxx>
Thanks,
Ilya
|