Re: [PATCH v4 3/5] xen/ppc: Define minimal stub headers required for full build

[Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>]

On 9/11/23 9:45 AM, Jan Beulich wrote:
> On 09.09.2023 00:50, Shawn Anastasio wrote:
>> Additionally, change inclusion of asm/ headers to corresponding xen/ ones
>> throughout arch/ppc now that they work.
>>
>> Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> albeit ...
> 
>>
>>  xen/arch/ppc/Kconfig                     |   1 +
>>  xen/arch/ppc/include/asm/altp2m.h        |  25 +++
>>  xen/arch/ppc/include/asm/bug.h           |   9 +
>>  xen/arch/ppc/include/asm/cache.h         |   2 +
>>  xen/arch/ppc/include/asm/config.h        |  10 +
>>  xen/arch/ppc/include/asm/cpufeature.h    |  10 +
>>  xen/arch/ppc/include/asm/current.h       |  43 ++++
>>  xen/arch/ppc/include/asm/delay.h         |  12 ++
>>  xen/arch/ppc/include/asm/device.h        |  53 +++++
>>  xen/arch/ppc/include/asm/div64.h         |  14 ++
>>  xen/arch/ppc/include/asm/domain.h        |  47 +++++
>>  xen/arch/ppc/include/asm/event.h         |  36 ++++
>>  xen/arch/ppc/include/asm/flushtlb.h      |  24 +++
>>  xen/arch/ppc/include/asm/grant_table.h   |   5 +
>>  xen/arch/ppc/include/asm/guest_access.h  |  68 +++++++
>>  xen/arch/ppc/include/asm/guest_atomics.h |  23 +++
>>  xen/arch/ppc/include/asm/hardirq.h       |  19 ++
>>  xen/arch/ppc/include/asm/hypercall.h     |   5 +
>>  xen/arch/ppc/include/asm/io.h            |  16 ++
>>  xen/arch/ppc/include/asm/iocap.h         |   8 +
>>  xen/arch/ppc/include/asm/iommu.h         |   8 +
>>  xen/arch/ppc/include/asm/irq.h           |  33 +++
>>  xen/arch/ppc/include/asm/mem_access.h    |   5 +
>>  xen/arch/ppc/include/asm/mm.h            | 243 ++++++++++++++++++++++-
>>  xen/arch/ppc/include/asm/monitor.h       |  43 ++++
>>  xen/arch/ppc/include/asm/nospec.h        |  15 ++
>>  xen/arch/ppc/include/asm/numa.h          |  26 +++
>>  xen/arch/ppc/include/asm/p2m.h           |  95 +++++++++
>>  xen/arch/ppc/include/asm/page.h          |  18 ++
>>  xen/arch/ppc/include/asm/paging.h        |   7 +
>>  xen/arch/ppc/include/asm/pci.h           |   7 +
>>  xen/arch/ppc/include/asm/percpu.h        |  24 +++
>>  xen/arch/ppc/include/asm/processor.h     |  10 +
>>  xen/arch/ppc/include/asm/random.h        |   9 +
>>  xen/arch/ppc/include/asm/setup.h         |   6 +
>>  xen/arch/ppc/include/asm/smp.h           |  18 ++
>>  xen/arch/ppc/include/asm/softirq.h       |   8 +
>>  xen/arch/ppc/include/asm/spinlock.h      |  15 ++
>>  xen/arch/ppc/include/asm/system.h        | 219 +++++++++++++++++++-
>>  xen/arch/ppc/include/asm/time.h          |  23 +++
>>  xen/arch/ppc/include/asm/vm_event.h      |  49 +++++
> 
> ... this file now wants dropping, and xen/arch/ppc/include/asm/Makefile
> instead indicating to use the asm-generic variant.
>

Got it -- I'll drop it and use asm-generic.

> Note further that xen/arch/ppc/include/asm/numa.h has a leftover Arm
> reference that likely wasn't meant to be there.
>

Good catch, will fix.

> Jan

Thanks,
Shawn