[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Sep 2023 10:02:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EWB9k4jgVV/49PCdTj9xF3VItfyOrDqS0rQTg6pzZB8=; b=Ce7rVxLjG2uwJ+XT59Dxm7HUJJAx6Jg8/p177BLrBGbmXJFrAO0mQu2kl/Op5d/EhtKC7QL34q1DX69CqlkWUxnQZWYZCNMrXP3qiWdNOWcpg23jaaLxyDBRJQTM4Ul4wQRTrguxXoYRqfpfMBDpM/88MoLMhp53v17wTRB2K/6c+bPT400lYEDO4vV3KAWIieUrD34UJY/KBBEB4wVuozYTdBwStIhTIEkjvbuhVX+FwconrDTButCvmV5ApefOc0c9/kWfTMj7u6BMY2eYCNrPbk9SMDWPc4Yxi3J3suYXu+m3hNCh1dat7KSzR0Q5tRTwDUh64292ktnh9Q+mrw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EHDJ5yUPtSw3xTNCcSgUv3sFH+JhLJRlTA+aLYFbFLzlJ2XHm0vt8T65Ng9ChuwtzGkgrKRxBzKm9snQFTF8fiE3pQ0IMkHsrM88R9DBYx5gaQs2TDU86Kryb66OfJndScptmbk9IteG9JwTy61xO4AzLLNF9/gNeLQnr3qr7d2dTU4sE2bNiVA1aU9ZPYRlDjtp89dOZ71WUrARUd8QolV+n20+mhL+yMx7spm952EhqxY/frE+ilA0SiAqFylffdsf6n1ZkeL9nYUNfjO648caObQKYiHqnxGEb+mhdN8Ob9o4WBAkThUJ7evv+NgY3mmgdHdaq9suTNcW0OxuoQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, sstabellini@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 13 Sep 2023 08:02:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.09.2023 11:36, Simone Ballarin wrote:
> Add or move inclusion guards to address violations of
> MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order
> to prevent the contents of a header file being included more than
> once").
>
> Inclusion guards must appear at the beginning of the headers
> (comments are permitted anywhere) and the #if directive cannot
> be used for other checks.
>
> Simone Ballarin (10):
> misra: add deviation for headers that explicitly avoid guards
> misra: modify deviations for empty and generated headers
> misra: add deviations for direct inclusion guards
> xen/arm: address violations of MISRA C:2012 Directive 4.10
> xen/x86: address violations of MISRA C:2012 Directive 4.10
> x86/EFI: address violations of MISRA C:2012 Directive 4.10
> xen/common: address violations of MISRA C:2012 Directive 4.10
> xen/efi: address violations of MISRA C:2012 Directive 4.10
> xen: address violations of MISRA C:2012 Directive 4.10
> x86/asm: address violations of MISRA C:2012 Directive 4.10
Just to mention it here again for the entire series, seeing that despite
my earlier comments to this effect a few R-b have arrived: If private
headers need to gain guards (for, imo, no real reason), we first need to
settle on a naming scheme for these guards, such that guards used in
private headers aren't at risk of colliding with ones used headers
living in one of the usual include directories. IOW imo fair parts of
this series may need redoing.
Jan
|
