[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/amd: do not expose HWCR.TscFreqSel to guests


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 13 Sep 2023 15:27:18 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9TNZRgQvr+4DsHfLUgK9M8OPsPc8fdmIgsCjCS6OwqA=; b=fVOLvUE2pj4TUvS91YvE46dfrqzyCn3ls0jP98LrMfsJ7dEaiTCnvfskF48f0cHc2Iz3C0S3sqLPnEycOxQwAcou7SLj8kJoKjLWuSs3oCl0pKtqDvPRYbwhgh2PvqbcOUCHUP2a9ph6wq+GLIaL5rkbHPYoGpOd1eV6hpulWR5SXxxslIyWfYHxxPBCVhfzLU3JKETx3bI2ivqAHQOOPl4Wse9ESPVUdwjMcJrpyabCzlq+WpBNoRoH2av0OLkRaPPK5CVwdlOUwFkuUDFlFh+kJ0QZbtsr8DRRgNTmstN/SnbB8NtE05AR/DPZOGm/X2jCqPX/ccEATDdrSt40kQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXRK4msRwUY6NWQEnBuQN9hT+zXfqHb+FwPOHZOmZFR17JpV1hUTahxOUuhzMMZ+Hqiw5DlwZO/8W6wpmRDTE2YoU3PdyL3pMALa+ojQFsJdv2rrfN8FN41lCaz2FXZihalrk/m1+/1f/2vf06LXOUS139RDf6yc8F1t9UCxVkGrTSoF5bmO6AMPSfkyAp49+76UbeMupQ+ch4kzsEbf9dKUma6MaP8V9keQNPzF6WD2au8/E8XcLTeaOL+y40HNNdtAzcYKftGY8cj2WdvDZyQZJmmNFY1w7A48PIn/eUyOV7TvAxssWLTYCRA3zbvPW5WpkmPFaZrGsknRV+BmTQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, solene@xxxxxxxxxxx, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 13 Sep 2023 13:27:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13.09.2023 12:50, Andrew Cooper wrote:
> On 13/09/2023 8:50 am, Roger Pau Monné wrote:
>> Hm, there's no written down note that TSC_FREQ_SEL implies PSTATE0 to
>> be available (and PSTATE0 is not an architectural MSR), but I can see
>> how a guest can expect to fetch the P0 frequency if it sees
>> TSC_FREQ_SEL.
> 
> The PPR is a reference of mostly autogenerated details and misc notes,
> put together in a non- hand-write way, unlike the older BKWGs.
> 
> Lots of the information elided from public and partner-NDA versions is
> "see TICKET/LINK for rational" type comments.
> 
> It is not a spec - it is a reference (the clue is even in the name)
> aimed at people already familiar with the area.  Do not fall into the
> trap of thinking it it can be read as a spec.

But then where is it written down that the bit set implies the PSTATEn
MSRs to exist?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.