[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/8] x86/entry: Adjust restore_all_xen to hold stack_end in %r14
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 14 Sep 2023 10:51:48 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/xpLRWMJeoA4uiNwQLu+0ffYTos7ZC54hw6Zsv0VRAg=; b=IG5/wsMGQ8D0omUZ3+1DoVMkAWwme9IMoYAmvR5+uSJXadyMzmSDPz+l5a2pgxeqDpOIssoFeeu/qYtLGT/nB++BZcv2ueDKLvnO8nKxvMvRzQKSqTpBOAEBQKvUYOx8LMF5CfX7FSOkQ8JygAgUtWZHfyh9qLiSDuC9nJj602qsqGsllZbkTrn1v7BQieGLTHxHzIG4+epvWcoP084EUnyKH9wD5mGyjsVNeZAXGMLSz+Xo0bgQxN7KB4byXSxdKp9D6ETW2YycbeHM4s62dgg3HbI0HL6UsQJrZWflEjb0Zt1zm0ZlwJWDctCI4N8B48WP8bncpeYHc6IsOMQE/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OtY8fkcxiGI3rwQsDMGWqgUY8J8ZGzdipPC9K1Wil2cEL4jKWg5IoAd1v9J5dF3jemW3VN1d2lL+a4Sy43fRWz3d4gdAeZ+aVRNKKQ8v5x+0/ZFSSHGN/AuQjhUluJVTpxrJPSOE9v5PViqVPRz/yfMWlhlbbi7VePvp15Icdn74cCAIQzvfAYl9k0FVPraX5hQ92qu94/3vfU3BW6Z5BAr2h/i0raqtoNPuhqx9YzzA9YYyTdHiGt6KYwRNNNv141qWG0hmEarNkL5szRopz0dF8olfWnIuhCtWe9vDriOQshg7VzOCXHnK1V10DzxUYCymP4Gcs0dFwo2gNzll/Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 14 Sep 2023 08:52:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.09.2023 22:27, Andrew Cooper wrote:
> All other SPEC_CTRL_{ENTRY,EXIT}_* helpers hold stack_end in %r14. Adjust it
> for consistency, freeing up %rbx to be used differently.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
The choice of %rbx was, iirc, for avoiding unnecessary code size increase
(due to extra REX prefixes needed in some of the affected insns). I
understand you view this as not a real concern, but I think saying so
explicitly in the description would be at least desirable. After all there
would also be the alternative of further parametrizing the involved macros.
Jan
|
