[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 00/29] Introduce stub headers necessary for full Xen build


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 14 Sep 2023 17:08:41 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yoQtXL3IRg9/PPW9aIWUlddxBRrcNauH0VNbULdeGcE=; b=QykpH3c6ZmvFNCq7LJBrh+rTrNPO0t91bVGvA/S8Ixf6jzJTTGZvVcG/XSgeMLoQh5YssccCFuDFoAD15w1Hxd+57o5CMNSvMscALYdhmS0ZD2z1mmeq7G645lN0q9vcH498JqvQgS8pItaR1UcJVcjVw9T2sF1VEzF4H64II10ukDwm/eg7XqhHb2pSUV9xHpJOkGfJLl2GA72UherKtRlHXW/BUgk8PIFFhLuz6nkMBJ4g1rmHyT5juKIKGtiwq09uaBF/isJcIBNnKLzSHcITLnXRK6in6DTL8StTPOadnmvCQVAV8WsRbN39sJ+tT7KiZsnMvdKQctkrOxQrew==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cjU3d0byNdz77L9rNN+yM5Yw5ngyOSyak01X5AbThoz1WkMD/tNJZPAINQTqfOpMkoTY75chcNW3bpi9c6LcNEEM3NP3D7pBP8GhhoimZCiwtbCJbpLXF9bOqZvowrR23XpgZU5IXscgkqKCWq/yShicKbp6DjUUfGuU3nAgX6QXfvYFR3nE1NfIufzK0xNURY7ibaG35v3cfEqudG1kPrQhPeyAxD3AqLq5/6Xz3KR9J1vsgLUH70CL25cifXXcBopdO0rInKUKvR9W0DHYrKde2qOhgb+Fx3yeeIn7b3RvKjhjkzbyp61aNKZUNKbGslcIXuzDbklmhDTOTrDjkw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 14 Sep 2023 15:08:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.09.2023 16:56, Oleksii Kurochko wrote:
> Based on two patch series [1] and [2], the idea of which is to provide minimal
> amount of things for a complete Xen build, a large amount of headers are the 
> same
> or almost the same, so it makes sense to move them to asm-generic.
> 
> Also, providing such stub headers should help future architectures to add
> a full Xen build.
> 
> [1] 
> https://lore.kernel.org/xen-devel/cover.1694543103.git.sanastasio@xxxxxxxxxxxxxxxxxxxxx/
> [2] 
> https://lore.kernel.org/xen-devel/cover.1692181079.git.oleksii.kurochko@xxxxxxxxx/
> 
> Oleksii Kurochko (29):
>   xen/asm-generic: introduce stub header spinlock.h

At the example of this, personally I think this goes too far. Headers in
asm-generic should be for the case where an arch elects to not implement
certain functionality. Clearly spinlocks are required uniformly.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.