[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 01/29] xen/asm-generic: introduce stub header spinlock.h
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 14 Sep 2023 17:35:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ngWffglW8oAO1benmUgzFd5MqLRVCH4wCdIhgxMQ79w=; b=j+mxnx/b0F+fx9h1DwzVeN1S+qnh5tg/mbV0uofyKdatXGze2CiaD7PeNbcSKfg6TmJJAi1t+vWTij6SkshlnxFlzboilEDy64dBi2FOVf57L+9xgDS6OkC1L9v+o2Rmk5Kte5F7D5VS+4LlSlFXtmPjWPjRr13sh2Aj0jF3x2y4SYk754DNswL7GvH/dY/TBTix7WdABkfaGlISFHtdgIOBeEh0D+z5R6fN06YtJj/mRVn79IKn9tZ1sINvcdm0vUChnKdsTSC4Uj5HrPUG8lZjOOlJTeGxmjhnK3LdmYdHDIFraizAxdIe/GeI8MXnystGaTPsGSL7HsO/zTBrDQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MCM1BMf55ToFI9fWvkSI6DyHaGY46v4Nr5RWZCXfqKlEGXIdBSOSOlcP+emq9oB8qSAJchRk2ML5Z+6vSxfRQteLKC6D2utIDWkydGVKIqfNXFzp7qLuT35dVCgrG8fZ3X4uiDRenQjQ8ap7AZ97N8+/IEPVMVH4qw4vUkkN3OsY6A1AXzaT3wV1UhsYAhNsN0xMP1y58LV4jAOuluE3/L6YuOVwK8ASHHrrVtWdxHpX40paU9RoJKyPwLTcjezm0ScpAorHy5vjxid+ONNfUwWuNP7hjd/Gc6ZiuNmL98g0yXDWmkqHDY2ue9A0mlCOdKRycGyyKdWBW8WEQxAAtw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 14 Sep 2023 15:35:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.09.2023 16:56, Oleksii Kurochko wrote:
> The patch introduces stub header needed for full Xen build.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Hmm, looking here I think I need to take back what I said in reply
to the cover letter, taking this as an example.
> --- /dev/null
> +++ b/xen/include/asm-generic/spinlock.h
> @@ -0,0 +1,23 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __ASM_GENERIC_SPINLOCK_H__
> +#define __ASM_GENERIC_SPINLOCK_H__
> +
> +#define arch_lock_acquire_barrier() smp_mb()
> +#define arch_lock_release_barrier() smp_mb()
> +
> +#define arch_lock_relax() cpu_relax()
> +#define arch_lock_signal() do { \
> +} while(0)
Slightly easier (and without style violation) as ((void)0)?
> +#define arch_lock_signal_wmb() arch_lock_signal()
How's the WMB aspect represented in here? I think you need the x86
variant as the generic fallback.
|
