[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 4/8] Arm: annotate entry points with type and size


  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 15 Sep 2023 09:00:58 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vFBszeExHVHK3rPmkhDPfcIX0seau8ijSyDiPy33SGk=; b=Vn0IBNn8HHvOQvA0z7j7eJAtTRp7VwtJG/IdL+pbI+3usNbhnfqLu/Dr8o0dGxwjgU36avFPcco+CU44m501O7/2ODM2iKI8dHL1CYMGIqVYGzJObCjOuKvijp/ExZLyq6T9FCJqdkCJRQQB4dfpAqBb9+4txoRHZj0pA1DtyTO0k9l4yVk74t4W5IyqEtitlqMOSwNH8Q8xnYWH5KQXnA1KGwlf6dGzNwaUmvTCQW6x0baBSSsiH91QESHe44OMeqZJ/tIR+p+/05rVOEgg1WyYdZ0904AFIDB3SPDxIL03jcxAONpLrAyll+ZHrZbt4nlY8yih5elKcnl76yI22w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FhKgKHtPQwQrMDDupmUprDPcmKvJLQR48IDlU8rwmaYMEjzjOl4WE0dFcKYYegTLi3fpVA8IVRX1XT1yhX9WtIALUvv2b9fMO+CsLnueDYWoSyKOVOsRJOoFPSo/xA2LGgzuBQeyOtXXmw7YBu7BYDZILsbuecqTzOfeO6Y7rTXt4k2yBiQzklq4S+PxzJhUTJFvsetmR0pevNIf+usTva63VXPZ4PGdAcDJD0kaWbTQNy06j3PDXnYz4XdYgFUjDFYFMPqZKL9r1ljy1H26TSkvWshXamR9v7AIW0bnRoRhZ4SBQYAJo6CobDJ/qYncbT6B4CkQsBsqyZmVXJlDzQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 15 Sep 2023 07:01:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.09.2023 23:25, Julien Grall wrote:
> On 04/08/2023 07:28, Jan Beulich wrote:
>> Use the generic framework in xen/linkage.h. No change in generated code
>> except for the changed padding value (noticable when config.gz isn't a
>> multiple of 4 in size). Plus of course the converted symbols change to
>> be hidden ones.
>>
>> Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only
>> use site wants the symbol global anyway.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Thanks.

>> ---
>> Only one each of the assembly files is being converted for now. More
>> could be done right here or as follow-on in separate patches.
> 
> I don't have a strong preference. Are you planning to do follow-up? (I 
> am ok if it is no).

Well, I certainly can, but I wasn't expecting this series to remain pending
for this long, so time's running out for 4.18.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.