[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/7] x86/emul: Fix and extend #DB trap handling
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 18 Sep 2023 13:28:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Vp9355iLGkTVXUnf6hvBqzjJYfAaWD4xULBV4BMvK8=; b=Zp5vxJe/tYtiWHaNzja473vZpCNoGNOtU3vADpzkoj4Zm/axzmb2WdJO9B7KgRsYwk5TqTt8Ap1eixZzxIgf9ml05VXu5UlvuQwpzgZVQl0njeWTvjISvYHAUTcehtEXftqV4WRtfR86qqBOkHiwtHcZMM2nXhkUD5fKcLqK3aqthDfuD6UrBrkLT84BArohHz3O+3zK5q8ZF0MCmHzxyl5I+8cyg19d4VH6YSYmEXrg7TAyI5xwNLG1Xm3Oo6AQvi+Fk+NWKrFZtyB+DhLtRoRQh7EaKxznFkqJbedsCXV4jNNSlU7jPx8Ksunz5tg6fWdtbz7/2PSg0+p1xFD0LQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ardmNVBHj5CI/XaX0K7HpaN9ROqTt8K1eZfW20UfAXKz/z7cLV2aAuLTCp5flimY5akWpEq6joQ0rqSREDg/g5MBx+eibTrjQMr2E12y1g69jxo2PU5fENDSw8CTqofbPHWL215PYR9N7bIyCbsmSU0t6Byb+PYsMMYCoIk65BBUOdxOi1HR3p7Arq6Y33W7qhm6SCoSMibZiKBnRBFJ6djHvEotaZNv7vt1KVR/AQL/q3UVZO5ANnXdPsVzlvA96XqcAOqpulNZOYuOJUxSJVRadN1b0tBQRZKr6MC3evCDQRgzGwt0mE/0mPedBcMEd0sh21/60GlY/dzEc8ED0A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jinoh Kang <jinoh.kang.kr@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 18 Sep 2023 11:29:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.09.2023 22:36, Andrew Cooper wrote:
> Lots of this is very very broken, but we need to start somewhere.
>
> First, the bugfix. Hooks which use X86EMUL_DONE to skip the general emulation
> still need to evaluate singlestep as part of completing the instruction.
> Defer the logic until X86EMUL_DONE has been converted to X86EMUL_OKAY.
Doesn't this warrant a Fixes: tag against 4999bf3e8b4c?
Jan
|
