[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] x86: Introduce x86_merge_dr6()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 18 Sep 2023 13:37:49 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OBBXnKDaDPIgpbRRjEy0lNB7lIJwAP4CIziXqymuf4o=; b=eIzaSZUl2PftkjntAdfhHLg8g7GikzcgPUJDRvbTlpYuFQt6rv50fIB3WIdmxipgnoxrNgTZnMqIspETQ6BmvGn9W3VZatyTeRqpIl28zzD7Vmqjss62a+UIS7CxNcqqQ3I2DZsnNLvOTx4xzuD0a/SCaB7CApSUcYnezZ8wU0kKH+6Nn1QXob4zgKgUJSTCfHtW/j4xoJOIb6qKs6Ea8j37xc4gW4l3iW8boRqxy5d4NwLXkwsw6XVXKy43VpiJ1tTUan3vRaQ+vc8Ywy6HcCFEgKNDdtvhaLdhNLbHCtoDBhDVs1xxnvg7x+WzznfDz964mqtQK5AxNrmu0QX4EQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4Mm9UQQ3TBegjQzNxa+czzVjgU46XLYtwuuKSl+0+/BsROYoUfjt6ha4+8rQi79MCxz/Ogbi3q9S02YWYHjfvA7uekQZtBT+osUb2QBZ6nN2qgv1CttTgNXfhvgd9Pk1QlTOq5PV4MJalpjMQ1R23wtDWZwnr3Jcw+eJeECkZ7ZSFRGE4pMubASHN+093K843YvWvw3bFaiwkxU2mQweTDcz2SafNBXuZtdBeTsJ1elqeML0TDt97iHdMNr0ENXpmSKq+arbyO/2oi3CqlcFk0mgK9tABXiu5mW7KlV3EJajysNGckhKLJPYvP9ggIJPijjZ4SBTeeZq/FBjCpvtw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jinoh Kang <jinoh.kang.kr@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 18 Sep 2023 11:38:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.09.2023 22:36, Andrew Cooper wrote:
> The current logic used to update %dr6 when injecting #DB is buggy.
>
> The SDM/APM documention on %dr6 updates is far from ideal, but does at least
> make clear that it's non-trivial. The actual behaviour is to overwrite
> B{0..3} and accumulate all other bits.
As mentioned before, I'm okay to ack this patch provided it is explicitly said
where the information is coming from. Just saying that SDM/PM are incomplete
isn't enough, sorry. With that added (can't really be R-b, I'm afraid):
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
