[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] xen/types: address Rule 10.1 for macro BITS_TO_LONGS


  • To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 19 Sep 2023 11:33:01 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qZXt98HxqLSuuwVXWNs76uXiXwfhgmUTGTmxcGdlXZ8=; b=B5OBva0p5yu08rWNbXkFyZ8rI/PTo1XqdSGCLCY7xINKB02SmpAZuA/cp66tSquFv9g887xRXMNI5MY/jA9S0w4sKy+jFV/7sooxkOxfVaQFCHB1f/d83yceoxlbqLIz9VNdI37CntR17WcK5j1ulzmrbPpagfEKbyD3EWcf57arAwJlSqovDUrySZ/anI5XwaRWrw26h6lG146cE0GDytxVVxM8npwbfnR4YQyzaj0xtTkqZB6gCKcU5EhXCq0wssF9x914mgVJvQUBwgVwR/b3psqvuo0lII8yF03aIOycTJpXuoTXm17ZvtbsNvea/Jqp+yuz6v3sdWAum+chhQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SEjL8KTEuOR7cWTA6alag0gUiC3bse78MUItygEg1xS9mI+/bQUnex/pKhiBUJgmmQE6S/FPnlnbDXOlTQp+BBDSD7uAM5cCt+0kC3i8VvO8pnRlGTNJ1M4TZ5tE16gs1ungEkQ+R42x7TCDP9o/1sgz7pE5ZnO1wPk8S8cFlVdBfHafHjIzZ301EGZ7sim31shwgEBBkEzzHFDBD9Jdsii3CSy12VbKhoxIqwTtHpxSB/qTqwUingC8PYTmY6kBcPg7oQNhSi786DyAu+xgxUHtlmtNng79dlB65ltGrH+Cfii/Z2S5zoaUm+WbHFicUVpGhwsQz8KBhdK+wCfAFA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Tue, 19 Sep 2023 09:33:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.09.2023 11:19, Nicola Vetrini wrote:
> I just noticed one further issue with making BYTES_PER_LONG unsigned, in 
> that causes
> several instances of (1U << 3) to appear inside the file 
> xen/arch/x86/xen.lds
> produced by the build, which in turn causes ld to fail on that 'U'.

That should be avoidable if _AC() is used in the #define.

Jan

> For 
> reference, the version of ld used by the build is the following:
> GNU ld (GNU Binutils for Ubuntu) 2.38
> 
> The following is a snippet of the output:
> 
>         . = ALIGN((1 << 12));
>         __ro_after_init_end = .;
>         __start_bug_frames = .;
>         *(.bug_frames.0)
>         __stop_bug_frames_0 = .;
>         *(.bug_frames.1)
>         __stop_bug_frames_1 = .;
>         *(.bug_frames.2)
>         __stop_bug_frames_2 = .;
>         *(.bug_frames.3)
>         __stop_bug_frames_3 = .;
>         *(.rodata)
>         *(.rodata.*)
>         *(.data.rel.ro)
>         *(.data.rel.ro.*)
>         . = ALIGN((1U << 3)); __start_vpci_array = .; 
> *(SORT(.data.vpci.*)) __end_vpci_array = .;
>    } :text
>    .note.gnu.build-id : AT(ADDR(".note.gnu.build-id") - (((((((261 >> 8) 
> * 0xffff000000000000) | (261 << 39))) + ((1 << 39) / 2)) + (64 << 30)) + 
> (1 << 30))) {
>         __note_gnu_build_id_start = .;
>         *(.note.gnu.build-id)
>         __note_gnu_build_id_end = .;
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.