[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/10] x86 setup: change bootstrap map to accept new boot module structures
- To: Christopher Clark <christopher.w.clark@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Sep 2023 15:51:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MTtWIWgqYS5XpeR+XCcErzNBzEjcrGPaQrGDrSJ9sDg=; b=dTTMbpqjdO62u3W9pFRo7vKvhQiDNuCKYhBkGiCfJsZ8mHiv7WRxJciPDBgvBQeZp8/yNdA7E5/DrJH8DjMFlUxegAn8utgOYlJ4B8FoTzLTSmr3GFAzEGLJoj1x5toGW2APbWR0qAn/FuuSMCmgMFkmbJ+0RYLCvyHgJAHhhCT/qlb7zvSalXSwqcK3M8itn5K2Fd1/mBC1E72iVOCTtSCYa9nm7qqiYtxns1Qoo+2mL4X6fKfHQoCs6J8vIRPtbFHWYvtPcdk9MAerHwd6wQfWpKRbVIPdYCSgQxC5Rin3ek9ki+Aq/h9W+HxLSqeMqob+7AxYMY7mDWZuAf2+zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hebtk4cyoeAUAxhjmx6Sl2ee2H2DGIJuF8Xmf8LqoHylzdeaAD0D3ehILgcuJUsD03iIKGTvfSFCkeIsk8oPYsBPUaWfyYAV6gdiCpYBWgCfo6MknuTbueRZ34ypbc5JVzOms7U7drDKykSJMjPs1bpBlbsWkTqYWoEZ4GTRdONe9CeYK5tM0JqmNhCCnnbGeb9/y7j01Bta0Whz3S8pb71OTOhzgcEa8xqDSem4Dk2imQ1EUYrB+Lcq0+r4/M9f5iEyVSEHPi+TDuQ+QQ6w6BJcoyxstSGIoGnSBorzpO5jIc8r4rz+Ud0pp20L+6KtaQcN7xRPcY1Q3BgpC9Hv6A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Rich Persaud <persaur@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Sep 2023 13:51:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.07.2023 09:18, Christopher Clark wrote:
> To convert the x86 boot logic from multiboot to boot module structures,
> change the bootstrap map function to accept a boot module parameter.
>
> To allow incremental change from multiboot to boot modules across all
> x86 setup logic, provide a temporary inline wrapper that still accepts a
> multiboot module parameter and use it where necessary.
And all uses of the original function are converted to the new wrapper,
except when passing NULL - am I getting this right? Plus down the road
you'll change all of them back? Too much code churn for my taste, to be
honest, not the least because this undermines easy use of "git blame".
If the above observation is right, and since passing NULL to the wrapper
is fine too, why don't you deal with this by using a macro wrapper
instead, without needing to touch all the call sites:
#define bootstrap_map(m) bootstrap_map_multiboot(m)
Misra won't like that, but as you say it's temporary.
Jan
|
