[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] console/serial: bump buffer from 16K to 128K
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 19 Sep 2023 16:14:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ajS2uRO6wnVyggQd4OqE5WGtuU97nQyAI7MNbKCh70=; b=QVFY6uwEDSyTbYDrkK6CKhr6iRMtgktkwexw5jxz01tk09siYYnDwrB2nYut1WvqMWzzqc/bcLxUTgMsg5RjmsCRUhIo+q2BVrLnGsQ49EUDwq0cGc5+0LahGiywxG74Mk16JUbmYLPtZc/y8DnIjeK5x22vmINW39Jm9vKbXSS4imlc+ydkG5Hi19y4+C/B5nIz8MaudmPl9IZRLtmth8bRB36+Jx5oi/qW9CPYAKnawFEp1ajMf3K9YMcD/eSFJRI9gSQaTD6SrbwAVMGyxN++gCEQDF+EARrEe237cZrhV685p3ioqVgb5CfpW2UdZwipw+2lXzjzitURvfGXcg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EVUGFn+AEcudLtd/JTGNSeAYe0ktlI+NCZ4459DhShtFzjFXBdjiAuBJhEFifoka98/sIHXKsvusXAVS8IYkrxBus0aUv6TCCbZIGYemESauvgZfUHVm6qdHcWjyASUDPrUidyvdu9FJxgzan3ZWImjzR3cybd6XklhPRkJmhdnD3/1mRxGK3J+GR9sarYDSUkj/iWCjmfrjj9g5DPnkn4VVF2aVCxX0D5yb45NwvN+2bxw07MmPr4+tKWC+0KfVOI/PPY5QSK3ByxIOMXg62ngnRHMZEzHjPDohXpECwy4AEya5PuAOaHrdp9hWKwMr4YGQ9WRbGtG2Uck3FORF7w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Sep 2023 14:15:13 +0000
- Ironport-data: A9a23:WRBnOKJqYHkLxZ9RFE+RHpQlxSXFcZb7ZxGr2PjKsXjdYENShjICn 2seXj+HOPffZDakKNx3Pdyx8BkFusSGmNRrQFRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAhk/nOHvylULKs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrZwP9TlK6q4mhA7wVvPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5HKGJvz t0GdQsGNBKy2OTxn4v4c9Zz05FLwMnDZOvzu1lG5BSBUbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTSCpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+tqyj12bOQxXKnMG4UPJiG/eNtslyI/TY4AUUXDnSykL68i2frDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O+8n7ACAzILE7gDfAXILJhZac8AvvsIyQT0s1 3eKksnvCDgpt6eaIVqC8p+EoDX0PjIaRUcSaClBQQYb7t3LpIAokgmJXttlCLSyjND+BXf32 T/ikcQlr7AajMpO26Dl+1nC226ovsKREl9z4RjLVGW46A8/fJSie4Gj9Vnc67BHMZqdSV6C+ nMDnqBy8dwzMH1ErwTVKM1lIV1jz63t3OH06bK3I6Qcyg==
- Ironport-hdrordr: A9a23:cIOgCqm0Tz59avng+QBcsWmRGsPpDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Sep 19, 2023 at 03:06:45PM +0200, Jan Beulich wrote:
> On 19.09.2023 14:51, Roger Pau Monne wrote:
> > Testing on a Kaby Lake box with 8 CPUs leads to the serial buffer
> > being filled halfway during dom0 boot, and thus a non-trivial chunk of
> > Linux boot messages are dropped.
> >
> > Increasing the buffer to 128K does fix the issue and Linux boot
> > messages are no longer dropped. There's no justification either on
> > why 16K was chosen, and hence bumping to 128K in order to cope with
> > current systems generating output faster does seem appropriate to have
> > a better user experience with the provided defaults.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > --
> > Changes since v2:
> > - Bump to 128K.
>
> Wow, I was hesitant about 32k, and now we're going all the way up to 128?
> Even the recent report indicated 24k would be fine there ...
24k would be rounded to 32k anyway.
I don't think 32k vs 128k makes that much difference, it's still an
infinitesimal part of the memory on any modern computer. Simply the
risk of loosing output is IMO not worth us being conservative with
the amount here, specially if we are speaking about KiB, not even MiB.
Thanks, Roger.
|