[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 06/16] vpci/header: implement guest BAR register handlers
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Wed, 20 Sep 2023 10:18:08 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AOkWYrKVa4rWt3ZBaP3oVAkeSEsIxBth2zVbNviXskI=; b=jcJ22Ng7qJahYZo4Qa6SSzZX548QT6GXN9nf2BFulFrO3xMs3rktdC2s4Qt/P0xgiqGzoI7bvOEEaAispfSujQ3+5hRNpCo2S0uAycEQXkZTUFihx9Ir27a5PUSTaznkXFFN/YtvHzk39r8hTFquJjjug075AOwqCxZ1QIB4XvMbMIKk8W+ye+cIbXE9ohdbjS7XaKYYbQQfKzWzvxjAJIulKnH2VTT8A9w7YSYnv4M5l76fT8uA55oeAS7+r7Dn7gflwX5YkWakKwvCSTG7Pcfj55qOashAtN9aqhHssXWYfG0ULGMK3N9m5h3It3Nj8IZh3DHFG4umFWJtQ2fsxw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XpCRpooaEAXaAqFDt2gUtgeGcCTUYpNtbfDwAOweUM7+PXd47FDOCW5sZhHvr+Glb8/ThZfPkTbfGKvndCrlL6y0hVCqR/XCYn0AifABlEubp5dT7qwO+SO7QotNs4D8zIfm1CvxJBZO5o1itEAUr2INf7ES2qBGxMDBQyfViQ+O9qt1BFhPXSTZwCRnithcBrCzJuIa7JCrUbf3NGybi4o3BySBugaj96DrKMYdiVEs6WvBnXGkiilwzWhBVc6TB5TOmXf0/0eD6lucglMOm5SUFubaTNnes5phNeSL4OuCHyqpKTQOyi57NlEs9AU2UUaZkGNJidUTUtZ80kw/LQ==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Delivery-date: Wed, 20 Sep 2023 14:18:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 9/20/23 05:49, Roger Pau Monné wrote:
> On Tue, Aug 29, 2023 at 11:19:43PM +0000, Volodymyr Babchuk wrote:
>> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
>> index e58bbdf68d..e96d7b2b37 100644
>> --- a/xen/drivers/vpci/header.c
>> +++ b/xen/drivers/vpci/header.c
>> +static uint32_t cf_check empty_bar_read(const struct pci_dev *pdev,
>> + unsigned int reg, void *data)
>> +{
>> + return 0;
>> +}
>
> If we are going to gain a lot of helpers that return a fixed value it
> might be worthwhile to introduce a helper that returns what gets
> passed as 'data'. Let's leave it as you propose for now.
For future reference, I introduce such a helper in the vPCI capabilities
filtering series [1]. If that series happens gets committed before this one, it
could be worthwhile making the switch. But since the helper is not upstream
yet, +1 for leaving as is for now.
[1] https://lists.xenproject.org/archives/html/xen-devel/2023-09/msg00796.html
|
