[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v10 13/38] x86/cpu: Add X86_CR4_FRED macro
- To: Nikolay Borisov <nik.borisov@xxxxxxxx>, "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-edac@xxxxxxxxxxxxxxx" <linux-edac@xxxxxxxxxxxxxxx>, "linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Li, Xin3" <xin3.li@xxxxxxxxx>
- Date: Wed, 20 Sep 2023 17:25:21 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HnsJ6gEOmNnvj/71iTWup15VcRue1W537zLLPwS1Xog=; b=PXvZupnhJnWDtMq4PVjqXEZQU1EcoLW4qK7IcGoivD/WQFG5vp/3Zm16qmFtijzB24KgC2bCHILA7GmPje/EZRDu3+Z9gFUuMBeLcUU+nqg2V66wLxlpGeGTyZvw7whp1HgpOB0nepMbP7rl6SBAm4QXhEbPe7qZwCYbfPcXayYr+p/btiOXDayHchVLkaQXDi16XSlaaoZJ7isDajFemmuG7cdDxcGVydTC4Mz0MTvoBdsV3ql7B3H1D30SNqMHmcIIelSCjUcT6AW/A/xg03tFQb4Xlhr3oG21lzLiYrhiYqarFdTanSDhlNQLVnZbPjtNn9Qbyp+QI6yVpH1kFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEZkxLsy+/FtV7Gd61jl4NpgMRe1e2n4/HUsFXebsMIyZsOUiEC58GXRUsM2QdA353VVof2KWhjpupF+MRJZ2T6mcEbcQDL51r3e73xRaai6F23o14Bvv70j7IEeXXBty6otYVNGQuUfOotCQY06901JfX7D5o6p2VHTscQ+dpVh9iiOAjo/GVG3WHEJ9Mkx6vuhGAGJEEwpEzmjYyarJkV8UhYvxn8tCIHeW4IDTAsXjsjL+lIpqhGlG/D1P8PJRAWX+FTNEa6iu8KxMGuA8BOLhWKBPi43A9CRoY8tFNhNuLc2eQKaOoMFgPklEIbDhZoCtcOGCOo9u/6tHqIGZg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "Lutomirski, Andy" <luto@xxxxxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>, "Christopherson,, Sean" <seanjc@xxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "Gross, Jurgen" <jgross@xxxxxxxx>, "Shankar, Ravi V" <ravi.v.shankar@xxxxxxxxx>, "mhiramat@xxxxxxxxxx" <mhiramat@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "jiangshanlai@xxxxxxxxx" <jiangshanlai@xxxxxxxxx>
- Delivery-date: Wed, 20 Sep 2023 17:25:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZ5ss+SatJUnh9UkGHEM3ubXu/u7AjkxCAgABt1KA=
- Thread-topic: [PATCH v10 13/38] x86/cpu: Add X86_CR4_FRED macro
> > +#ifdef __x86_64__
> > +#define X86_CR4_FRED_BIT 32 /* enable FRED kernel entry */
> > +#define X86_CR4_FRED _BITUL(X86_CR4_FRED_BIT)
>
> nit: s/BITUL/BITULL I guess if __x86_64__ is defined then we are
> guaranteed that unsigned long will be a 64 bit, but for the sake of
> clarity I'd rather have this spelled out explicitly by using BITULL
>
UL is better because CR4 is a machine word.
>
>
> > +#else
> > +#define X86_CR4_FRED (0)
> > +#endif
|
