[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/7] migration: Clean up local variable shadowing
- To: Markus Armbruster <armbru@xxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>
- From: "Zhijian Li (Fujitsu)" <lizhijian@xxxxxxxxxxx>
- Date: Thu, 21 Sep 2023 06:06:58 +0000
- Accept-language: en-US, zh-CN
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Czt4Vqpqpa8teNewGt1ClwS8K2U8gOZZ2ifKnLuwLlk=; b=oQCV8B/zu27Yn/cMabHC4FFy/PFwL6n6PkEn5Z+3oTPYciWEKJJReM9tTibNA5dw9B+R1SPCvkQOYYiUkEKG20FxnZUB4BjJAB1IjPUBHUmlK2Ffjl3bKj7Yb/9pFt3yx7Wla1v4GSU8dGKdv4W1ueU+2xVXthxUYygkzRC+7+rtXcMQ9Y1AZSbtBo20vub7jxBcuDfhMOcONF8AA7gi8WqDxvIAKGekWRSwpTXxj/EwU4862M5bzWwCfurxfFOyUx10E4avRf3e5Dtl++I8jQ8ByGF26jhKwLaSEwUWW9E89Swx6Z0X+T/J81v5jyedU25D7ABNgak6lbRisNnzZg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oS84lbm1VkLQLa1v0tWXgF7+S5W5BjnNDbn8V8V8OMcrkeMF/4R1aOFHs7YnVLkPeD2VmU/AGkNxzHH4wFxXHnpq0mAWaeGWX1tTQT4F8XNTX64aEGxkq3LIzWuuF99Dzly7/TMsNRapJ+116GXbPEM3J+wkATFI3i+8tp6W98WvlRblXjiPSa6XqCZedZU6lEROhrA+cHdF4BAbauoEqj3XvbsMnTXyQ2yhWpJbEy2GAjO0Od50X2pWrI/OHwGu32KSxqHJF1FZ95BXWHzztFQL50Edv4cfKxZMaN3t5eYr/S/sm29qdJDc0Ai2h+zMUp06yXcRmxNHng0cQSI+PA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com;
- Cc: "kwolf@xxxxxxxxxx" <kwolf@xxxxxxxxxx>, "hreitz@xxxxxxxxxx" <hreitz@xxxxxxxxxx>, "eblake@xxxxxxxxxx" <eblake@xxxxxxxxxx>, "vsementsov@xxxxxxxxxxxxxx" <vsementsov@xxxxxxxxxxxxxx>, "jsnow@xxxxxxxxxx" <jsnow@xxxxxxxxxx>, "idryomov@xxxxxxxxx" <idryomov@xxxxxxxxx>, "pl@xxxxxxx" <pl@xxxxxxx>, "sw@xxxxxxxxxxx" <sw@xxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "anthony.perard@xxxxxxxxxx" <anthony.perard@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>, "marcandre.lureau@xxxxxxxxxx" <marcandre.lureau@xxxxxxxxxx>, "berrange@xxxxxxxxxx" <berrange@xxxxxxxxxx>, "thuth@xxxxxxxxxx" <thuth@xxxxxxxxxx>, "philmd@xxxxxxxxxx" <philmd@xxxxxxxxxx>, "stefanha@xxxxxxxxxx" <stefanha@xxxxxxxxxx>, "fam@xxxxxxxxxx" <fam@xxxxxxxxxx>, "quintela@xxxxxxxxxx" <quintela@xxxxxxxxxx>, "peterx@xxxxxxxxxx" <peterx@xxxxxxxxxx>, "leobras@xxxxxxxxxx" <leobras@xxxxxxxxxx>, "kraxel@xxxxxxxxxx" <kraxel@xxxxxxxxxx>, "qemu-block@xxxxxxxxxx" <qemu-block@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "alex.bennee@xxxxxxxxxx" <alex.bennee@xxxxxxxxxx>, "peter.maydell@xxxxxxxxxx" <peter.maydell@xxxxxxxxxx>
- Delivery-date: Thu, 21 Sep 2023 06:07:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZ6/D0hSSeiTIhfkazdX4/frS54bAky8QA
- Thread-topic: [PATCH v2 2/7] migration: Clean up local variable shadowing
On 21/09/2023 02:31, Markus Armbruster wrote:
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand. Tracked down with -Wshadow=local.
> Clean up: delete inner declarations when they are actually redundant,
> else rename variables.
>
> Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>
> Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>
Reviewed-by: Li Zhijian <lizhijian@xxxxxxxxxxx>
|
