[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/7] block/vdi: Clean up local variable shadowing
- To: Markus Armbruster <armbru@xxxxxxxxxx>
- From: Kevin Wolf <kwolf@xxxxxxxxxx>
- Date: Thu, 21 Sep 2023 10:29:41 +0200
- Cc: qemu-devel@xxxxxxxxxx, hreitz@xxxxxxxxxx, eblake@xxxxxxxxxx, vsementsov@xxxxxxxxxxxxxx, jsnow@xxxxxxxxxx, idryomov@xxxxxxxxx, pl@xxxxxxx, sw@xxxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, paul@xxxxxxx, pbonzini@xxxxxxxxxx, marcandre.lureau@xxxxxxxxxx, berrange@xxxxxxxxxx, thuth@xxxxxxxxxx, philmd@xxxxxxxxxx, stefanha@xxxxxxxxxx, fam@xxxxxxxxxx, quintela@xxxxxxxxxx, peterx@xxxxxxxxxx, leobras@xxxxxxxxxx, kraxel@xxxxxxxxxx, qemu-block@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, alex.bennee@xxxxxxxxxx, peter.maydell@xxxxxxxxxx
- Delivery-date: Thu, 21 Sep 2023 08:30:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben:
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand. Tracked down with -Wshadow=local.
> Clean up: delete inner declarations when they are actually redundant,
> else rename variables.
>
> Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>
> Reviewed-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Reviewed-by: Kevin Wolf <kwolf@xxxxxxxxxx>
|
