[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] credit: Don't steal vcpus which have yielded
- To: George Dunlap <george.dunlap@xxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 22 Sep 2023 01:30:36 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s+WsQJ+PBJm+W9JYsD8tDKoIcVxsXAFEaZYWIMcTypc=; b=OQ0Bhew8MqUkF+7gXGKOV8v69lbgcbOZEdwbQQOztSV2Se2byKPRzBQgmdkOv8wuPq4VHN2Id6ewgskqBJTsMpCb0ShKgPwmna129npHSQP7W+i3LYWvOjBiUpSvaB3c7uAouAg/labrQ92EldmmLmZpoMfsaT7nymEfOXqc/6kJ4IVja6J+t64A4GQclNbJZY1OmHgm1VT8VDScsDk7/9q/TdVnUKe8PTyxuBN9DpnpZc6jttGvLxAiVtakN81lM7pn+idT0+OI677amUYUZIQFDkptK6W3VyQGvU8n2aTuJEh9SLZO7uiF79eVEG+vdd3aOYz3hxEUdwEI5GOZWQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i+mT+ubCO7SR2ED4GCB60mMmlo58Atv+ytxdH1prtjrNq0uFNWGQA3frBBIZ68oaUWD7hslPkPhSC1h+7T6ChWRR+dxWoKj1vNb7BJ1thI2hpru5dQFDtQx6R5jGFVRIEbnsTzQNceDaUT6S2DypoilvJUzRbNtsGQyevWxWZRVmPsyQxMu+yKf59er5pwx59sWX/cP9lTD0WD29Pp/21W7u7rufdXtYHTOcjIHAu3znoPlfLehe92SrXdSl71VO/97WhAiFeqBMssPwS/tuTUz6Yc1YPy16j6n/XlSd2dL6ATZLY+xWcz9bC+Pp0d7I0qZVq4Bpj2PebvyUGblHpA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>
- Delivery-date: Fri, 22 Sep 2023 01:30:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ7IaORUrMbawngUSqIrYhJSNv+rAmD6wA
- Thread-topic: [PATCH v2 2/2] credit: Don't steal vcpus which have yielded
Hi George,
> On Sep 21, 2023, at 20:23, George Dunlap <george.dunlap@xxxxxxxxx> wrote:
>
> On large systems with many vcpus yielding due to spinlock priority
> inversion, it's not uncommon for a vcpu to yield its timeslice, only
> to be immediately stolen by another pcpu looking for higher-priority
> work.
>
> To prevent this:
>
> * Keep the YIELD flag until a vcpu is removed from a runqueue
>
> * When looking for work to steal, skip vcpus which have yielded
>
> NB that this does mean that sometimes a VM is inserted into an empty
> runqueue; handle that case.
>
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|