[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/4] pdx: Add CONFIG_PDX_COMPRESSION as a common Kconfig option
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 25 Sep 2023 11:46:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BVC4/YVXjTRU1z6NZv9YDCFCTz6txPE0WbZ8eFg7mPk=; b=j8/WPWtGkJUb+zCT+DIsiz4apTNZE/Bit/4E2IHGNnjH/kkZbdyz8Y62AnSqhr0JCaqnq/lsgVWNodTXG7K88ZaR05izAVBXVLDgxrPlmS58IVmBGgMJMm9zqjCaI8dEfifCDVJYcEXhwp+8zOXASYeG9plOs1fLQKxtsy226ABbNqAIPIz/TVc5V5pzl3DnaVRP0hot2eAJUL0/b4EEeEMDr1Qk8e64FDHV7bkBjQjeCpf2TbjoQc3LYjh+HkM1/IjTm6CFGUbYy35CV0xfy0Hia99GErIzbMQOyqVCUfn5nuULX+bBLYx8oHyXnidZx32lEoLcSqEQQJGPYfpUOg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hMB7lvIplLW/BrsHRdegmYBE1dfyoOvDq3/qztKmon1jxA4Oripd+zeodetJTAOF7lflqmhKac2MWRC5qECf+JMtzEzgY2IaXP4ZWXbIKWoyGYOBFac01IFa8i1tv16DaAR22bL7JMg84ldOJNUprTKP6l6m6emwvsDiGPTI04dVcA3gQ23aiZ8c1NF9aBn5q6zmUQvLnnFG/sACY2QD8mCPNBvgmeCCeLXUhOimds7O1cMKSQYpQeT7XsKWCSazhIBuyaFJQTlfh5brUX1/zWGj974cZww9zMtwOFPIV0O3mjyhfrl+fHBZdcEwYAVMN4qYDxURr2CKM2J7gGIo/Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 25 Sep 2023 09:47:07 +0000
- Ironport-data: A9a23:TJIiLahk+khE5m+dPZNqxVmxX161AhAKZh0ujC45NGQN5FlHY01je htvCD+APvyCYmWmftkia46x8U0BsMOHn9VjTFBoriBgHnwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOhTraCYmYoHVMMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyp0N8klgZmP6sT7QWCzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQzNwwqbBeBmdvtnq2hevdGxdQsCsTSadZ3VnFIlVk1DN4AaLWbH+Dv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMqluGyb7I5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXqhA91KTubkppaGhnWJyEMsWDEKX2efmqK21Re6cY5EF HMtr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLP+BqQDGUASj9HafQludUwSDhs0 UWG9/vrGDhuvbu9WX+bsLCOoluaMyUPMXULYyNCSAIf+sTiu6k6lBeJRdFmeIaLidnyFSD10 iq9hiE0jLUOjuYGz6y+u1vAhlqEuZzhXgMzoALNUQqN7AxjbYqhT4Wt4Erc67BLK4PxZnmMu mIV3feX6u8mBIuI0ieKRY0lFbWk5f+DPCfbx0BmG50s9TOF8HqkYIwW6zZ7TG95P8BBdTL3b Uv7vQJK+IQVLHasdbVwYY+6F4It16eIPc/sUPnPctNVY59Zbgaf4CZ0aEif3mbgnVItl655M pCeGftAFl4fAKVjiT+pHeEU1Od3wjhknDyMA5fm0x6gzLySImaPTqsIO0ePaeZ/676YpALS8 JBUMM7iJwhjbdASqxL/qeY7RW3m51BibXwqg6S7rtK+Hzc=
- Ironport-hdrordr: A9a23:fwaRg6p/Abmhsp4popZYwFoaV5queYIsimQD101hICG9Kvbo8v xG785rsSMc6QxhKk3I9urgBEDtexnhHNtOkOss1NSZLXzbUQmTTL2KhLGKq1bd8m/Fh41gPM xbH5SWfeefMbEMt6nHCWeDfurIi+P3l5xAzd2uqUtFXEVhbql79Qd3CgySD01xQ2B9dOIE/b Snl7F6T43LQwVvUizga0N1JdQqhLDw5e/biV5qPW9Z1OHB4AnYloITXXKjr2Qju4Ej+8ZfzU HV1xH87r+u9+q20APYygbonuVrscqk199KHsDJlcQPMDXrjW+TFfRcZ4E=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Sep 25, 2023 at 08:36:03AM +0200, Jan Beulich wrote:
> On 22.09.2023 22:03, Andrew Cooper wrote:
> > On 08/08/2023 2:02 pm, Alejandro Vallejo wrote:
> >> --- a/xen/common/Kconfig
> >> +++ b/xen/common/Kconfig
> >> @@ -23,6 +23,16 @@ config GRANT_TABLE
> >>
> >> If unsure, say Y.
> >>
> >> +config PDX_COMPRESSION
> >> + bool "PDX (Page inDeX) compression support" if EXPERT
> >
> > This still needs hiding on x86. The minimal hack for 4.18 is "if EXPERT
> > && !X86".
>
> If you insist on complete hiding and I insist on allowing it to be used by
> people who want to play with exotic hardware, then this won't go anywhere.
> I think I've come far enough with accepting a compromise, and so I think
> it's your turn now to also take a step from your original position.
Just because I'm not familiar with this, is there any x86 hardware
that has such sparse memory map that would benefit from PDX?
Wouldn't anyone doing bring up on such exotic hardware also likely need to
perform other adjustments to Xen, and hence commenting out the !X86 in
Kconfig be acceptable? (we would likely make it selectable at that
point if such platforms exist).
Thanks, Roger.
|