Re: [PATCH v2 1/2] automation: Change build script to use arch defconfig

[Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>]

On 9/26/23 2:56 PM, Andrew Cooper wrote:
> On 26/09/2023 7:54 pm, Shawn Anastasio wrote:
>> diff --git a/automation/scripts/build b/automation/scripts/build
>> index b4edcf010e..19dd9e8270 100755
>> --- a/automation/scripts/build
>> +++ b/automation/scripts/build
>> @@ -22,7 +22,12 @@ if [[ "${RANDCONFIG}" == "y" ]]; then
>>      # RANDCONFIG implies HYPERVISOR_ONLY
>>      HYPERVISOR_ONLY="y"
>>  else
>> -    echo "CONFIG_DEBUG=${debug}" > xen/.config
>> +    # Start off with arch's defconfig
>> +    make -C xen defconfig
>> +
>> +    # Drop existing CONFIG_DEBUG and replace with value of ${debug}
>> +    sed -i 's/^CONFIG_DEBUG=[yn]//g' xen/.config
>> +    echo "CONFIG_DEBUG=${debug}" >> xen/.config
> 
> Kconfig is latest-takes precedence, which is why we always append for
> this and the other related options.  There's no need for sed to drop the
> old value.
>

Thank you for the confirmation. I'll go ahead and drop the sed.

> ~Andrew

Thanks,
Shawn