Re: [XEN PATCH v2 3/3] automation/eclair: build docs/misra to address MISRA C:2012 Dir 4.1

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 27/09/2023 15:29, Nicola Vetrini wrote:
> On 27/09/2023 11:52, Nicola Vetrini wrote:
> > The documentation pertaining Directive 4.1 is contained in docs/misra.
> > The build script driving the analysis is amended to allow ECLAIR to
> > analyze such file.
> >
> > Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> > ---
> > Changes in v2:
> > - removed useless make flags
> > ---
> >  automation/eclair_analysis/build.sh   | 6 +++---
> >  automation/eclair_analysis/prepare.sh | 4 ++--
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/automation/eclair_analysis/build.sh
> > b/automation/eclair_analysis/build.sh
> > index ec087dd822fa..ea7a1e5a59b0 100755
> > --- a/automation/eclair_analysis/build.sh
> > +++ b/automation/eclair_analysis/build.sh
> > @@ -34,11 +34,11 @@ else
> >  fi
> >
> >  (
> > -  cd xen
> > -
> > +  make -C docs misra
> >    make "-j${PROCESSORS}" "-l${PROCESSORS}.0"    \
> >         "CROSS_COMPILE=${CROSS_COMPILE}"         \
> >         "CC=${CROSS_COMPILE}gcc-12"              \
> >         "CXX=${CROSS_COMPILE}g++-12"             \
> > -       "XEN_TARGET_ARCH=${XEN_TARGET_ARCH}"
> > +       "XEN_TARGET_ARCH=${XEN_TARGET_ARCH}"     \
> > +       -C xen
> >  )
> > diff --git a/automation/eclair_analysis/prepare.sh
> > b/automation/eclair_analysis/prepare.sh
> > index 0cac5eba00ae..ebd5a2dde676 100755
> > --- a/automation/eclair_analysis/prepare.sh
> > +++ b/automation/eclair_analysis/prepare.sh
> > @@ -35,8 +35,8 @@ else
> >  fi
> >
> >  (
> > -    cd xen
> > -    cp "${CONFIG_FILE}" .config
> > +    ./configure
> > +    cp "${CONFIG_FILE}" xen/.config
> >      make clean
> >      find . -type f -name "*.safparse" -print -delete
> >      make -f ${script_dir}/Makefile.prepare prepare
> Hi, I observed a failure when running the analysis job of this series
> through patchew, so
> I think it's a good idea to put this patch on hold until I've figured
> out what's wrong.
> Sorry for the inconvenience.
I found the culprit; there is a minor issue with patches 2/3 and 3/3.
I'll submit a new one and address the other review comments as well.
The changes will be minimal, so perhaps I will be able to retain the 
R-by-s.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)