Re: [XEN PATCH v6 2/7] x86/hvm: address violations of MISRA C:2012 Rule 7.2

[Simone Ballarin <simone.ballarin@xxxxxxxxxxx>]

On 13/09/23 11:44, Jan Beulich wrote:
> On 12.09.2023 17:38, Simone Ballarin wrote:
> > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> > headline states:
> > "A 'u' or 'U' suffix shall be applied to all integer constants
> > that are represented in an unsigned type".
> >
> > Add the 'U' suffix to integers literals with unsigned type.
> >
> > For the sake of uniformity, the following change is made:
> > - add 'U' suffixes to 'mask16' in 'stdvga.c'
> >
> > Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> > Signed-off-by: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
> Comparing with v5 - are the two tags in the correct order? And is there
> a From: Gianluca missing now? Apart from that I'm now okay with the
> changes presented here.
>
> Jan
The commit is new and it has been obtained splitting a previous commit 
made by Luparini. Currently Luparini is not working on that, for this 
reason I'm the author of the new commit.
I thought that the first signed-off tag should be the commit author, 
this is the reason why I've changed the order.
--
Simone Ballarin, M.Sc.

Field Application Engineer, BUGSENG (https://bugseng.com)