[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN v1] xen: arm: procinfo.h: Fixed a typo


  • To: Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Ayan Kumar Halder <ayankuma@xxxxxxx>
  • Date: Thu, 28 Sep 2023 13:08:14 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fe3NYOEuIOZwDAafggleyOdpQk6WXMnGNJeKTzyllKo=; b=ZY7HSTNxtkOiF0XCGFo46or9bj8MOJIIfD7nnuXNL5S4CKeceCQrB1AxNt4mL02n1hMBUTUDcl67Sa7he0klg12fyjlw/C8k6aVg2b0Nt9mE959SSu6QU7aVa4RrdB+9XdHWgiHX/SzjMnasTKJAVWqAn7tCmK4Rc4lKeKvvvexZBPSAGtzogxTudgdk7nw083u2vyfOC8/wrZFTIvQ2Biq5ZA4ng+aednbF6HK3ggJKMkQ2ssiM+EBH2m31gP6G3bUSj8U2/FxSOdCkHZmp3T1RyfD9l3FYXT0whBl/qlYEUJzPgGTO1JnJkYla+dWMLbdVjGhsvcN1WyDuPpHpbg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DIFE6dgB60Rtj5HQozgbre7byYLMQhS0iUDGK4Wk3vlobtHh9XzjYjG3ow41SUyFq9usO2lvYzVY9VPQzR5jOBaOlWI8iHTL94uQ7XT7Zn3KYIWxWNHK0E1M/NjZ94SjtTa2gZbNQkw2aD6dwmXO/QxzouST29dc9u2MVx2ZouqgVVtTHX68cin8KLeApwTSe+uvyUloGolXfqqsRL5v+mln6w2bhVRpCpgXL9I89H/F1weorZSBdAO8/Z80mr4ThKVyIuIyUDYCbi1jECOeMCPhyIGEGbO110v6Ylr3xGuQVWNT24ZDugaMcYWVyzEja06RFv9VXblfyaMvdNYhWg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: sstabellini@xxxxxxxxxx, stefano.stabellini@xxxxxxx, bertrand.marquis@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx
  • Delivery-date: Thu, 28 Sep 2023 12:08:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 28/09/2023 12:57, Julien Grall wrote:

Hi Ayan,
Hi Julien,

On 28/09/2023 12:48, Ayan Kumar Halder wrote:
Change VPCU to VCPU.

Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
---
  xen/arch/arm/include/asm/procinfo.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/procinfo.h b/xen/arch/arm/include/asm/procinfo.h
index 02be56e348..8b8dae3dd4 100644
--- a/xen/arch/arm/include/asm/procinfo.h
+++ b/xen/arch/arm/include/asm/procinfo.h
@@ -24,7 +24,7 @@
  #include <xen/sched.h>
    struct processor {
-    /* Initialize specific processor register for the new VPCU*/
+    /* Initialize specific processor register for the new VCPU*/

As you are modifying the line, can you also add the missing space before */?

I have also a slight preference for using vCPU over VCPU.

I will address both of your suggestions and send a v2.

Just fyi, I see vCPU and VCPU used interchangebly.

xen/arch/arm/include/asm/new_vgic.h uses VCPU.

xen/arch/arm/vgic-v2.c uses vCPU.


With that addressed:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,
- Ayan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.