[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/15] sgi-xp: Remove the now superfluous sentinel element from ctl_table array
- To: j.granados@xxxxxxxxxxx
- From: Steve Wahl <steve.wahl@xxxxxxx>
- Date: Thu, 28 Sep 2023 12:51:15 -0500
- Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>, willy@xxxxxxxxxxxxx, josh@xxxxxxxxxxxxxxxx, Kees Cook <keescook@xxxxxxxxxxxx>, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Clemens Ladisch <clemens@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Doug Gilbert <dgilbert@xxxxxxxxxxxx>, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Corey Minyard <minyard@xxxxxxx>, Theodore Ts'o <tytso@xxxxxxx>, "Jason A. Donenfeld" <Jason@xxxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Robin Holt <robinmholt@xxxxxxxxx>, Steve Wahl <steve.wahl@xxxxxxx>, Russ Weight <russell.h.weight@xxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 28 Sep 2023 17:52:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Sep 28, 2023 at 03:21:36PM +0200, Joel Granados via B4 Relay wrote:
> From: Joel Granados <j.granados@xxxxxxxxxxx>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@xxxxxxxxxxxxxxxxxxxxxx/)
>
> Remove sentinel from xpc_sys_xpc_hb and xpc_sys_xpc
>
> Signed-off-by: Joel Granados <j.granados@xxxxxxxxxxx>
> ---
> drivers/misc/sgi-xp/xpc_main.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c
> index 6da509d692bb..c898092ff3ac 100644
> --- a/drivers/misc/sgi-xp/xpc_main.c
> +++ b/drivers/misc/sgi-xp/xpc_main.c
> @@ -109,8 +109,7 @@ static struct ctl_table xpc_sys_xpc_hb[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec_minmax,
> .extra1 = &xpc_hb_check_min_interval,
> - .extra2 = &xpc_hb_check_max_interval},
> - {}
> + .extra2 = &xpc_hb_check_max_interval}
> };
> static struct ctl_table xpc_sys_xpc[] = {
> {
> @@ -120,8 +119,7 @@ static struct ctl_table xpc_sys_xpc[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec_minmax,
> .extra1 = &xpc_disengage_min_timelimit,
> - .extra2 = &xpc_disengage_max_timelimit},
> - {}
> + .extra2 = &xpc_disengage_max_timelimit}
> };
>
> static struct ctl_table_header *xpc_sysctl;
>
> --
> 2.30.2
>
I assume you'll match the rest of the changes with regards to the
trailing comma.
Reviewed-by: Steve Wahl <steve.wahl@xxxxxxx>
--
Steve Wahl, Hewlett Packard Enterprise
|