[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bitmap: fix n__ signess
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 29 Sep 2023 08:25:45 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZv4QVXxFhqWRtjh+/NfpMtiqTMZziieLu2FrKUZ4OE=; b=j9YShkCB/WVpr/+c3Kg9betbP4KkHiZE4Gk/hmegW3BkJ0MnfAn6nMSogO+hGuzRwEC5C0XxpDW46SYvvAfgHdQQuJ21cS9o8fQFzRJkeeGOjAHIYRkptRdQIQDpBy4Ql0WTF6jYitgYG5BkrKy38C+NklsFiRhxmPTBvnkxWROwXhKup6QEg/iSUaGgdZSIEXy9qKcucCKdc5b2tx+9QOyFumqHQVznwxjLB1uo9OvYyB9PrwgoLeu0qz/rgDPbwUyuVd/1tja/8gwDNZ9DfwUXQsNaqPWohHl2BElBcTFk9ApOZa+tdSAGQg9bHpJi3W8sNXrqk19gn2rOdUw46w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PD8YdJp16RiuPfyyByu5lndAeaRblX9IWXBkY2YpyzUbQqUJT8ZSrpnFf1i5GIEHlspr8wctyU66vluNRTmQv3dKADDRQf3l8J6AEqgwh7HrbTSY4KsH1PwF2DRYKqZxnVSKVFDXIJ4ISZXBmxIRx4cCP8VhzyYRNkRsZBw6RGFSahvjUHRDuYPW0SSr9migd4gn60fzvXarl+vKWJ82HVfO1k6gczKaOVNaNtsQkp8Hn8IWYuazr+KRiyBSkCP8CV+pzKd1GonU5I8ybbJknpi77jbWtforEIML6Yvfw749D7FvyA8+BFHICpWrqg3tWVwfuS3MxztHfWIMdLPpuw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>
- Delivery-date: Fri, 29 Sep 2023 08:26:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ8mJT1hRW8AvsV0W7X8Uoqm4UN7AxZzyAgAARBwA=
- Thread-topic: [PATCH] bitmap: fix n__ signess
> On 29 Sep 2023, at 08:24, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Stefano,
>
> On 29/09/2023 00:19, Stefano Stabellini wrote:
>> All callers of the bitmap_switch macro (which are all within bitmap.h)
>> pass an int as first parameter. Do not assign it to an unsigned int
>> potentially introducing errors.
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
>> ---
>> We could also have gone the other way and change all the callers and the
>> callers' callers to use an unsigned int instead, but I went for the path
>> of least resistance.
>
> I understand this will solve the issue right now because the callers are all
> passing 'int'. However, all the callers will need to switch to 'unsigned int'
> in order to solve violations in their callers.
I was about to send a patch like this but Stefano beat me sending this one,
anyway I confirm that switching the callers type will solve this violation.
Cheers,
Luca
|
