Re: [PATCH 2/2] Update Xen version to 4.18-rc

[Julien Grall <julien@xxxxxxx>]

Hi,

On 29/09/2023 09:07, Henry Wang wrote:
> > On Sep 29, 2023, at 16:04, Juergen Gross <jgross@xxxxxxxx> wrote:
> >
> > On 29.09.23 09:58, Julien Grall wrote:
> > > From: Julien Grall <jgrall@xxxxxxxxxx>
> > > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> > > ---
> > >   README       | 16 ++++++++--------
> > >   SUPPORT.md   |  2 +-
> > >   xen/Makefile |  2 +-
> > >   3 files changed, 10 insertions(+), 10 deletions(-)
> > > diff --git a/README b/README
> > > index a491c8dce55b..f45e1ef1cdca 100644
> > > --- a/README
> > > +++ b/README
> > > @@ -1,11 +1,11 @@
> > > -###############################################
> > > -__  __            _  _    _  ___
> > > -\ \/ /___ _ __   | || |  / |( _ )
> > > - \  // _ \ '_ \  | || |_ | |/ _ \
> > > - /  \  __/ | | | |__   _|| | (_) |
> > > -/_/\_\___|_| |_|    |_|(_)_|\___/
> > > -
> > > -###############################################
> > > +#################################################
> > > +                  _  _    _  ___
> > > +__  _____ _ __   | || |  / |( _ )       _ __ ___
> > > +\ \/ / _ \ '_ \  | || |_ | |/ _ \ _____| '__/ __|
> > > + >  <  __/ | | | |__   _|| | (_) |_____| | | (__
> > > +/_/\_\___|_| |_|    |_|(_)_|\___/      |_|  \___|
> > > +
> > > +#################################################
> > Is it on purpose to use "xen" instead of "Xen"?
> I actually had the same question, but not sure if it really matters so didn’t
> add any comments… Do we have some convention on this? So far I
> have seen “xen”, “XEN” and “Xen” in different contexts.
I don't know if there are any convention. But we usually try to keep 
consistent within the same file.
In this case, the original word was with a uppercase 'x'. So I should 
have kept as-is.
Cheers,

--
Julien Grall