[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] SUPPORT: downgrade Physical CPU Hotplug to Experimental
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 2 Oct 2023 13:46:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x6ITXp0TzCTokxYzzck5rBzSqDm/s87w5+WFgz8Ixb4=; b=Vb3negxzrV+LT/C7ENMVuS5V+s+3j4zBNxyR7MsSxzDZejz/frNEuxY07C8ug6WsuzONzHRm+ab/1WY9kQLL8cRquRz09t6OFNRrGA3p7ba4ldlfsggH1hXIjmuRv/Dl30aEawny2MD8F2b86UQKxY4aVSHps+Bawh3nTJgCrDMup0uzU2a3DdyjL8hEAJJiG6yCIheBKB2RvFWi6+W8sp+Hhb5e4hOeiFHIJu5bqqLl5+fryMtBZGnIDkDALbmdxRxUIWGzROLCZQeN/4ApSu02gCiH1eaaJ4AwzoFIk+hcX2qaIUzkO6ogJq/GI/72lBzN9WD6kgC94dycfh3ihw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qyw6z1hWb+I32FbmB6vCLHmvtkryraEgFqirKwe8pMUqNLOlUXxT74mObvbu24fUNqQ6H4PFvapQ9HIwiRuN9h9ZSrovyzH+ci4If9pXlPVd18cF3kdo2lxerQ+lCZDIHYuF8nR4x2M2PmqSWeEFf3zE7njvSfEf5oWPVgLMU5CdELkguHWH/UuYr7ZyRDIA/dMElJvtsA34lQ7/mk3O8H9mvg7e9jA3/Su4fdOcqDtS7w8/zQumPX1mAX9zU8EAN5QvasMZSU5AwLrTvXsr0rNraQiCz/zKEV1TEbo9gU2o2V38CL9pGv0eqlQJc15hRfh2AXWXbxsFcV/W6rLu2Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, julien@xxxxxxx, bertrand.marquis@xxxxxxx, wl@xxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxx>
- Delivery-date: Mon, 02 Oct 2023 11:47:24 +0000
- Ironport-data: A9a23:VGYouqyxJt1MafeLK/96t+ezxyrEfRIJ4+MujC+fZmUNrF6WrkUPx mBLDG2OaamCZmGgeo8gbY2w9EMF7JfUmtNmTwE6/CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjPzOHvykTrecZkidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EgHUMja4mtC5QVmPaoT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWJy6 NlIMhEhVTOCtu+Uxr+8QOpOp9t2eaEHPKtH0p1h5RfwKK9+BLrlHODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDCVlVQvuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE37WQxHmqCNNOfFG+3sdnjlqsmzISMg8tWVuci/bhs2iEdOsKf iT4/QJr98De7neDVcLhVhe1pHqFuB80WNdKFeA+rgaXxcL84QyUG2wFRT5pc8E9uYk9QjlC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt4cTnoYw1pgLCSJBkCqHdptf4Ay3qy jaG6i03nawOjNUj3r++u1vAhlqEuZzhXgMzoALNUQqN9R90aoejYMqz9VHR4PJELYCYZlCEs D4PnM320QwVJZSElSjISuNSGrisvq6BKGeF2QApGIQ9/TOw/XLlZZpX/Dx1OEZuNIADZCPtZ 0jQ/whW4fe/IUeXUEO+WKrpY+xC8EQqPY2Nuiz8BjaWXqVMSQ==
- Ironport-hdrordr: A9a23:O0Gcb6upgQjiWtEv/2QW3lJK7skDWdV00zEX/kB9WHVpm62j+/ xG+c5x6faaslkssR0b9+xoQZPwJE80l6QU3WBhB9aftWDd0QPDQb2KhrGSoAEIdReOjtJ15O NNdLV/Fc21LXUSt7eA3OG0eexQp+Vu/MqT9IXjJ30Gd3APV0i41XYeNu9MKDwOeDV7
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Sep 28, 2023 at 01:48:59PM -0700, Stefano Stabellini wrote:
> On Thu, 28 Sep 2023, Roger Pau Monné wrote:
> > On Thu, Sep 28, 2023 at 11:32:22AM +0200, Jan Beulich wrote:
> > > On 28.09.2023 10:32, Roger Pau Monné wrote:
> > > > On Wed, Sep 27, 2023 at 04:20:04PM -0700, Stefano Stabellini wrote:
> > > >> From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> > > >>
> > > >> The feature is not commonly used, and we don't have hardware to test
> > > >> it,
> > > >> not in OSSTest, not in Gitlab, and not even ad-hoc manually by
> > > >> community
> > > >> members. We could use QEMU to test it, but even that it is known not to
> > > >> work.
> > > >
> > > > I think this last sentence is ambiguous. QEMU ACPI CPU hotplug
> > > > implementation does work AFAIK, it's Xen implementation of ACPI
> > > > hotplug that explodes (or so I've been told). I would drop or reword
> > > > the "but even that it is known not to work." part of the sentence.
> > >
> > > Maybe simply add "... on our end"?
> >
> > WFM.
>
> Just to be clear we are going for:
>
> "The feature is not commonly used, and we don't have hardware to test it,
> not in OSSTest, not in Gitlab, and not even ad-hoc manually by community
> members. We could use QEMU to test it, but even that it is known not to
> work on our end."
>
> Can the change be done on commit?
LGTM.
Feel free to add my Reviewed-by: Roger Pau Monné
<roger.pau@xxxxxxxxxx>.
Thanks.
|
