[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 02/10] x86/shim: zap runstate and time area handles during shutdown
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx, henry.wang@xxxxxxx
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Mon, 2 Oct 2023 17:11:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=01vEMBP+AIsrC5NQCk+WSSYp1tHvGShg3O7HS4rvvmM=; b=ZdBgjig6tiAgD3a86CEFS52LshXs2fivotR/NV+NNC8UbW0FcaLtqwvDwQjzYWvu85PeoHyqvcfIl0xokJLGckGQPD5YgbfG/t9lghxndm3U9Aj2lodGJcGvrcQxNBkY/Zs/c3914+qxG5lUXyHhYSJTnjLi3dS8w5E5pJs3PhrDYR8FFWR10FLt2/2vghEmt/J1AscWiuF3ZjqKVXk7f9g0tlguidAtkyVcEAiJiWVFHZh6JEMp1Vd5ofvBr7yG9CM2u5ZjcnxkLbK9dyxdrZlHBk6u/1EwgjZusQmFsPTYpqiR3U23GK6oZfg7lMrw3Sl6n/d/lBp8p2/Atg48MQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dX0LlBbrKw93fSZJ3C3CRrVKFzifI13yNHHqojUJlW8Zx3AfkzEKJE4R4/zMlx2h9UTIgx26n34S5DYyRajc5ubIEU8dMf9z6sOcChweydj8MBtq7Sy0NwmDreaATBiYdbOWwzm5BKuBw4lS6I3sBFA5elY/OIyn2b1Khxqs7QR0IG1tPAV/EkpkjHvVNuhZ+t9Rjw0BloQrjj/+oKbpvaaMdalrKcaM7O1qJSr1TYKhlhNTLEUMsj85P3d0Im8ek/zBD7ZY1XoR/j+k6dXLShySg1hVA/cd8yGB1To6RUUlhGICJVI+WbTLTgDZ4WUPUfGazHIm+gLse1qHVil/Jw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 02 Oct 2023 15:12:06 +0000
- Ironport-data: A9a23:8TnVnaiAEbhhYJevwu59SV1rX161UhEKZh0ujC45NGQN5FlHY01je htvX26BOa2JYDTyf49xa4vko0kFuMfVztVgTAtr/Cs3QyMb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOhTraCYmYoHVMMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyp0N8klgZmP6sS5AeEzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQpdyoVfgzcttmM++m6dMVjpul6PvDkadZ3VnFIlVk1DN4AaLWaGuDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEuluGyabI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXqhA9xPT+TpqJaGhnWthTE2MyYuTmCGgtnnqlOmfo5fG l0br39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOtMIwXy1sy VaPkPvgHzkpu7qQIVqf/LqJqTK5OQAOMHQPIyQDSGMt/N3LsIw1yBXVQb5e/LWdi9T0HXT8x m6MpS1n3rEL15dUjuO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComVPlhSATlrD0xIYyU
- Ironport-hdrordr: A9a23:lnW5YqlK8d23J/uohQM/nNdh27fpDfLa3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRcdcLW7UpVoLkmyyXcY2+cs1PKZLWvbUQiTXeZfBOnZsl7d8kTFn4Yw6U 4jSdkaNDSZNzNHZK3BkW2F+rgboeVu8MqT9JjjJ3UGd3AVV0m3hT0JezpyESdNNXl77YJSLu vk2iLezQDQBEj+aK6AdwE4dtmGnfLnvrT8byULAhY2gTP+8Q9BuNbBYmOlNg51aUI0/Ysf
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
From: Jan Beulich <jbeulich@xxxxxxxx>
While likely the guest would just re-register the same areas after
a possible resume, let's not take this for granted and avoid the risk of
otherwise corrupting guest memory.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
xen/arch/x86/pv/shim.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index ca0e639db323..7e4bacf7ae40 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -385,6 +385,10 @@ int pv_shim_shutdown(uint8_t reason)
/* Unmap guest vcpu_info pages. */
unmap_vcpu_info(v);
+ /* Zap runstate and time area handles. */
+ set_xen_guest_handle(runstate_guest(v), NULL);
+ set_xen_guest_handle(v->arch.time_info_guest, NULL);
+
/* Reset the periodic timer to the default value. */
vcpu_set_periodic_timer(v, MILLISECS(10));
/* Stop the singleshot timer. */
--
2.42.0
|
